Repository navigation
Chore: update to net10 incl. related packages and removal of Mediatr dependency - #19
Merged
Merged
Conversation
…s for compatibility
…Service to use AgentOutputFileCreatedHandler
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Direct handler injection captures a typed HTTP client for the hosted service’s lifetime, preventing normal factory rotation.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Migrates the solution to .NET 10, refreshes dependencies, and replaces MediatR-based file notifications with direct handler invocation.
Changes:
- Targets .NET 10 across all projects and publishing configuration.
- Updates centralized package versions.
- Removes MediatR and directly registers/invokes the output-file handler.
| File | Description |
|---|---|
Directory.Packages.props |
Updates dependencies and removes MediatR versions. |
global.json |
Selects the .NET 10 SDK. |
publish/publish-agent.ps1 |
Publishes for net10.0. |
publish/published-latest-version.txt |
Advances published version metadata. |
src/QF.BySoft.Entities/QF.BySoft.Entities.csproj |
Targets .NET 10. |
src/QF.BySoft.Integration/QF.BySoft.Integration.csproj |
Targets .NET 10 and removes MediatR. |
src/QF.BySoft.Integration/Extensions/DependencyInjectionExtensions.cs |
Directly registers the event handler. |
src/QF.BySoft.Integration/Features/AgentOutputFile/AgentOutputFileCreated.cs |
Removes the MediatR notification interface. |
src/QF.BySoft.Integration/Features/AgentOutputFile/AgentOutputFileCreatedHandler.cs |
Converts the notification handler to a regular class. |
src/QF.BySoft.Integration/Features/AgentOutputFile/AgentOutputFileWatcherService.cs |
Invokes the handler directly. |
src/QF.BySoft.LocalData/QF.BySoft.LocalData.csproj |
Targets .NET 10. |
src/QF.BySoft.Manufacturability/QF.BySoft.Manufacturability.csproj |
Targets .NET 10. |
src/QF.BySoft.Tests/QF.BySoft.Tests.csproj |
Targets .NET 10. |
src/QF.Integration.Common/QF.Integration.Common.csproj |
Targets .NET 10 and removes MediatR. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| public static void AddFileWatchFeature(this IServiceCollection services) | ||
| { | ||
| // register agent output file created handler | ||
| services.AddTransient<AgentOutputFileCreatedHandler>(); |
…ctory for handler resolution and add unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update to net10 incl. related packages and removal of Mediatr dependency