Skip to content

finish_pw_contextの動画保存処理を修正 - #47

Merged
yacchin1205 merged 1 commit into
RCOSDP:mainfrom
NishikawaKoharu:feature/playwright-finish-context
Aug 10, 2026
Merged

finish_pw_contextの動画保存処理を修正#47
yacchin1205 merged 1 commit into
RCOSDP:mainfrom
NishikawaKoharu:feature/playwright-finish-context

Conversation

@NishikawaKoharu

Copy link
Copy Markdown
Contributor

Purpose

Fix unstable video saving and cleanup in finish_pw_context, and make Playwright session shutdown and recording export more reliable.

Changes

  • Save videos with page.video.save_as() after closing pages, instead of copying from video.path()
  • Prevent duplicate cleanup by fixing the shutdown flow
  • Close pages before closing the browser context
  • Increase the finish_pw_context timeout from 30 seconds to 60 seconds
  • Delete the temporary directory only when it exists

Ticket

https://redmine.devops.rcos.nii.ac.jp/issues/62226

Custom Test Configuration

  • RDM_REPOSITORY:
  • RDM_BRANCH:
  • RDM_MERGE:
  • OSF_IMAGE:
  • EMBER_IMAGE:
  • CAS_IMAGE:
  • MFR_IMAGE:
  • WB_IMAGE:
  • EXCLUDE_NOTEBOOKS:

@yacchin1205 yacchin1205 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。マージします。(Flowable Rolesのテスト失敗については、mainに合流後調査します。)

@yacchin1205
yacchin1205 merged commit 4076071 into RCOSDP:main Aug 10, 2026
203 of 240 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants