fix unit test for log messege resources

src/server/clients/groups.py

@@ -91,10 +91,6 @@ def search(
         by_alias=True,
     )
 
-    from contrib import dump
-
-    dump(auth_params | attributes_params | query_params, "groups_search_query")
-
     response = requests.get(
         f"{config.MAP_CORE.base_url}{MAP_GROUPS_ENDPOINT}",
         params=auth_params | attributes_params | query_params,
@@ -104,8 +100,6 @@ def search(
         timeout=config.MAP_CORE.timeout,
     )
 
-    dump(response.text, "groups_search_response")
-
     if response.status_code > HTTPStatus.BAD_REQUEST:
         response.raise_for_status()
 
@@ -216,10 +210,6 @@ def post(
             alias_generator(name) for name in exclude
         ])
 
-    from contrib import dump
-
-    dump(auth_params | payload, "groups_post_payload")
-
     response = requests.post(
         f"{config.MAP_CORE.base_url}{MAP_GROUPS_ENDPOINT}",
         params=attributes_params,
@@ -230,8 +220,6 @@ def post(
         timeout=config.MAP_CORE.timeout,
     )
 
-    dump(response.text, "groups_post_response")
-
     if response.status_code > HTTPStatus.BAD_REQUEST:
         response.raise_for_status()
 

src/server/clients/services.py

@@ -214,10 +214,6 @@ def post(
             alias_generator(name) for name in exclude
         ])
 
-    from contrib import dump
-
-    dump({"request": auth_params} | payload, "service_post_payload")
-
     response = requests.post(
         f"{config.MAP_CORE.base_url}{MAP_SERVICES_ENDPOINT}",
         params=attributes_params,
@@ -228,8 +224,6 @@ def post(
         timeout=config.MAP_CORE.timeout,
     )
 
-    dump(response.text, "service_post_response")
-
     status_code = response.status_code
     if status_code not in {HTTPStatus.BAD_REQUEST, HTTPStatus.CONFLICT}:
         response.raise_for_status()

src/server/clients/users.py

@@ -91,10 +91,6 @@ def search(
         by_alias=True,
     )
 
-    from contrib import dump
-
-    dump(auth_params | attributes_params | query_params, "users_search_query")
-
     response = requests.get(
         f"{config.MAP_CORE.base_url}{MAP_USERS_ENDPOINT}",
         params=auth_params | attributes_params | query_params,
@@ -104,8 +100,6 @@ def search(
         timeout=config.MAP_CORE.timeout,
     )
 
-    dump(response.text, "users_search_response")
-
     if response.status_code > HTTPStatus.BAD_REQUEST:
         response.raise_for_status()
 

tests/unit/api/test_callback.py

@@ -1,11 +1,9 @@
 import inspect
 import typing as t
 
-import pytest
-
 from server.api.callback import auth_code
 from server.api.schemas import OAuthTokenQuery
-from server.exc import CredentialsError, OAuthTokenError
+from server.exc import CredentialsError, DatabaseError, OAuthTokenError
 
 
 if t.TYPE_CHECKING:
@@ -14,34 +12,57 @@
 
 def test_auth_code_redirect(mocker: MockerFixture):
     """Normal case: valid code should redirect"""
-    mock_issue = mocker.patch("server.services.token.issue_access_token")
+    mocker.patch("server.services.token.issue_access_token")
     query = OAuthTokenQuery(code="valid_code", state="abc123")
-    expected_status_code = 302
-    expected_location = "/"
+    expected_status_code = 200
+    expected_result = ""
 
     original_func = inspect.unwrap(auth_code)
-    response = original_func(query)
+    result, status = original_func(query)
 
-    assert response.status_code == expected_status_code
-    assert response.location == expected_location
-    mock_issue.assert_called_once_with("valid_code")
+    assert result == expected_result
+    assert status == expected_status_code
 
 
-def test_auth_code_credentials_error(mocker: MockerFixture):
-    """Error case: token.issue_access_token raises CredentialsError"""
-    mocker.patch("server.services.token.issue_access_token", side_effect=CredentialsError("Invalid code"))
+def test_auth_code_oauth_token_error(mocker: MockerFixture):
+    """Error case: token.issue_access_token raises OAuthTokenError"""
+    mocker.patch("server.services.token.issue_access_token", side_effect=OAuthTokenError("Invalid code"))
     query = OAuthTokenQuery(code="", state="abc123")
+    expected_status_code = 202
+    expected_result = ""
 
     original_func = inspect.unwrap(auth_code)
-    with pytest.raises(CredentialsError):
-        original_func(query)
+    result, status = original_func(query)
 
+    assert result == expected_result
+    assert status == expected_status_code
 
-def test_auth_code_oauth_token_error(mocker: MockerFixture):
-    """Error case: token.issue_access_token raises OAuthTokenError"""
-    mocker.patch("server.services.token.issue_access_token", side_effect=OAuthTokenError("Invalid code"))
+
+def test_auth_code_database_error(mocker: MockerFixture):
+    """Error case: token.issue_access_token raises DatabaseError"""
+    mocker.patch("server.services.token.issue_access_token", side_effect=DatabaseError("Database error"))
     query = OAuthTokenQuery(code="", state="abc123")
 
+    expected_status_code = 202
+    expected_result = ""
+
     original_func = inspect.unwrap(auth_code)
-    with pytest.raises(OAuthTokenError):
-        original_func(query)
+    result, status = original_func(query)
+
+    assert result == expected_result
+    assert status == expected_status_code
+
+
+def test_auth_code_credentials_error(mocker: MockerFixture):
+    """Error case: token.issue_access_token raises CredentialsError"""
+    mocker.patch("server.services.token.issue_access_token", side_effect=CredentialsError("Invalid code"))
+    query = OAuthTokenQuery(code="", state="abc123")
+
+    expected_status_code = 202
+    expected_result = ""
+
+    original_func = inspect.unwrap(auth_code)
+    result, status = original_func(query)
+
+    assert result == expected_result
+    assert status == expected_status_code