Add WEKO_ACCOUNTS_SHIB_ROLE_MANUAL_ASSIGN for role preservation - #1890
Merged
Conversation
…oles Shibboleth login clears and recalculates user roles on every check_in. In environments where the IdP does not send isMemberOf, this wipes the roles an administrator set from the admin screen and can refuse the login entirely. Add WEKO_ACCOUNTS_SHIB_ROLE_MANUAL_ASSIGN (default False). When True, ShibUser.check_in() returns immediately so no role is cleared, assigned from shib_role_authority_name, or bound from Gakunin mAP groups. The existing behavior is unchanged when the flag is off. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shibboleth login clears and recalculates user roles on every check_in. In environments where the IdP does not send isMemberOf, this wipes the roles an administrator set from the admin screen and can refuse the login entirely.
Add WEKO_ACCOUNTS_SHIB_ROLE_MANUAL_ASSIGN (default False). When True, ShibUser.check_in() returns immediately so no role is cleared, assigned from shib_role_authority_name, or bound from Gakunin mAP groups. The existing behavior is unchanged when the flag is off.