Skip to content

Use Default Interface Methods #136

Description

@tb-mtg

Just as suggestion, have you considered moving repeated implementation logic code into their interfaces by taking advantage of default interface methods?

For example, the following overrides could be removed from:
https://github.com/RCommon-Team/RCommon/blob/main/Src/RCommon.Linq2Db/Crud/Linq2DbRepository.cs

public override IQueryable<TEntity> FindQuery(ISpecification<TEntity> specification)  
{
  ... // Logic moved into ILinqRepository.cs
}

public async override Task<IPaginatedList<TEntity>> FindAsync(IPagedSpecification<TEntity> specification, CancellationToken token = default)
{
  ... // Logic moved into ILinqRepository.cs
}

and moved into:
https://github.com/RCommon-Team/RCommon/blob/main/Src/RCommon.Persistence/Crud/ILinqRepository.cs

public interface ILinqRepository<TEntity> : IQueryable<TEntity>, IReadOnlyRepository<TEntity>, IWriteOnlyRepository<TEntity>, 
  IEagerLoadableQueryable<TEntity> 
  where TEntity : IBusinessEntity 
{
  ...
  IQueryable<TEntity> FindQuery(ISpecification<TEntity> specification) 
    => FindQuery(specification.Predicate);


  Task<IPaginatedList<TEntity>> FindAsync(IPagedSpecification<TEntity> specification, CancellationToken token = default) 
    => FindAsync(specification.Predicate, specification.OrderByExpression, specification.OrderByAscending, specification.PageIndex, specification.PageSize, token);

  ...
}

Activity

  1. JasonMWebb commented on Jul 24, 2024

    @JasonMWebb
    Collaborator

    That is a nice language feature. I'm pretty close to finishing the hardening of version 2.0 and then am quickly moving on to version 2.0.1 where we'll need to begin changing the interfaces in this area. It may be a nice time to look at cleaning up the code a bit with something like default interface methods. Nice recommendation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions