Repository navigation
fix(desktop): videos/audio never indexed in packaged apps (0.5.1) - #1
Merged
Merged
Conversation
…peg from app.asar.unpacked
require('ffmpeg-static') resolves inside app.asar; Electron patches execFile for asar
but not spawn, so every packaged release since 0.2.0 failed all video/audio with
spawn ENOTDIR (macOS) / ENOENT (Windows). Dev builds and Docker have no asar, so tests
missed it. Shared getFfmpegPath() maps to app.asar.unpacked; on startup, videos that
failed this way are reset and re-indexed. scripts/packaged-video-check.sh indexes
videos with the packaged app. Version 0.5.1.
… the ffmpeg binary skipped by --ignore-scripts
…e.runIf only skips tests) — move into beforeAll
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported on V2EX: on macOS every video fails with
spawn ENOTDIR.Cause —
require('ffmpeg-static')resolves to a path insideapp.asar. Electron patchesexecFilefor asar paths but notspawn, so in every packaged desktop build since 0.2.0 all video/audio indexing failed (ENOTDIRon macOS,ENOENTon Windows). Dev builds and the Docker image have no asar, which is why tests missed it.Fix
getFfmpegPath()(src/core/video/ffmpegPath.ts) maps the path toapp.asar.unpacked; used by video, audio and capture.spawn ENOTDIR/ENOENT,frame_count = 0) are reset and re-indexed automatically.scripts/packaged-video-check.sh: indexes videos with the packaged app; run before each release.Verified
spawn ENOTDIR(reproduced).npm test358 passed,test:dbok, typecheck clean.