Repository navigation
fix: EPIPE on a closed stdout no longer raises a main-process error dialog (0.5.1) - #2
Merged
Merged
Conversation
…s error dialog Launching Vixel from a terminal and then closing it (or piping its output to a reader that exits) made the next console.log throw EPIPE as an uncaught exception. Swallow EPIPE on stdout/stderr in the desktop main process and the server; regression test reproduces the crash in a child process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launching Vixel from a terminal and then closing it (or piping its output into a reader that exits early) made the next
console.logthrowwrite EPIPEas an uncaught exception → "A JavaScript error occurred in the main process" dialog.src/core/stdioGuard.ts: swallowEPIPEon stdout/stderr (other stream errors still throw); imported at the top of the desktop main process and the server.src/core/stdioGuard.test.ts: spawns a child that keeps logging, closes its stdout after one byte — without the guard it dies with an uncaught EPIPE (bug reproduced), with it it exits 0.npm test: 360 passed.