Skip to content
This repository was archived by the owner on Sep 11, 2026. It is now read-only.

index.html: get job details per AJAX - #11

Open
miri64 wants to merge 1 commit into
RIOT-OS:masterfrom
miri64:frontend-job-details
Open

index.html: get job details per AJAX#11
miri64 wants to merge 1 commit into
RIOT-OS:masterfrom
miri64:frontend-job-details

Conversation

@miri64

@miri64 miri64 commented Sep 9, 2018

Copy link
Copy Markdown
Member

This is still somewhat unstable, because if there is a currently building job that has failed jobs, the click event for all links is fired multiple times for some reason (causing the details not to be shown).

@miri64

miri64 commented Sep 9, 2018

Copy link
Copy Markdown
Member Author

@cladmi I believe you asked for something like this ;-)

@miri64

miri64 commented Sep 10, 2018

Copy link
Copy Markdown
Member Author

I think the problem is that during building the status row is completely rewritten everytime the websocket sends a message instead of being updated on the fly :-/... This is actually pretty tricky to rewrite and would require some kind of global state for the PRs in the Javascript. So I would prefer to go ahead with the current (slightly broken) solution and rewrite the PR view construction at a later point.

@kaspar030

Copy link
Copy Markdown
Contributor

We could change parse_output.py to re-send the last update after a maximum period (e.g., 1sec or 5sec). Another option would be to cache the last status at the websocket handler, then directly send it to new connections.

@kaspar030

Copy link
Copy Markdown
Contributor

Nice, eh? frontend, backend, middleend, so many places to put logic.

@miri64

miri64 commented Sep 21, 2018

Copy link
Copy Markdown
Member Author

I tried some statehandling in the frontend (instead of just replacing GUI, like it is now). The only downside to that was, that the jobs aren't listed alphabetically any more and static tests weren't at the top...

@miri64

miri64 commented Sep 21, 2018

Copy link
Copy Markdown
Member Author

Nice, eh? frontend, backend, middleend, so many places to put logic.

Welcome to webdev ;-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants