Skip to content

import: handle unrecognized workbook rows #993

Open

Description

@jacobvjk

Current situation

When the importer can't match a workbook row to a pathway, it skips that row and lists it at the end of the report. The rest of the import still goes ahead.

Problem

That makes it easy to miss a pathway. A typo in the abbreviation, or a pathway the importer hasn't been set up for yet, means the row is quietly left out. This week, 11 rows were skipped because they hadn't been set up yet.

Options

  • Keep it as it is. Skipped rows are only listed in the report. This works well when the workbook includes pathways that aren't ready to import yet.
  • Stop the import when any row isn't recognised. Nothing gets missed, but every row in the workbook has to be set up in the importer first.

Both options assume new pathways still have to be set up in the importer by hand. Whether that step can go away is tracked in #994. If it does, far fewer rows would go unrecognised, so this decision becomes less important.

Raised in review of #992.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions