Repository navigation
fix: full publisher name in the timeseries download when there is no short one - #987
Merged
Merged
Conversation
The timeseries CSV read only publication.publisher.short. TransitionZero's four timeseries files carry a full name only, so their downloads had an empty publisher column and a source starting with "undefined" (found by the benchmark prep repo's review workbook, RMI/tpr_benchmark_data_preparation#18). publisherLabel now uses the short name, or the full name where there is none, for both columns, the same rule the review workbook uses, so the two match. Only the four TransitionZero CSVs change; every other file builds byte-identical. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Expected version change and release notes🚨 WARNING: This PR is not expected to trigger a new versionTo trigger a version bump, use at least one conventional commit message in this branch. See: https://www.conventionalcommits.org/en/v1.0.0/ |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-987.westus2.2.azurestaticapps.net |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix correctly covers both affected CSV fields with appropriate unit tests.
0 open findings
What changed in this PR
Fixes timeseries CSV metadata when publishers have no short name.
Changes:
- Adds a short-name-to-full-name fallback helper.
- Uses it for CSV
publisherandsourcefields. - Adds unit tests for short, missing, and blank names.
| File | Description |
|---|---|
scripts/timeseries-csv.ts |
Adds publisherLabel. |
scripts/build-timeseries-files.ts |
Applies the fallback during CSV generation. |
scripts/timeseries-csv.test.ts |
Tests publisher-label selection. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AlexAxthelm
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug: the timeseries CSV download read only
publication.publisher.short. TransitionZero's four timeseries files carry a full name only, so their downloads had:publishercolumnsourcecolumn starting with the literal text "undefined"This was found by the benchmark prep repo's review workbook (RMI/tpr_benchmark_data_preparation#18): the workbook and TPR's download matched in every value except these.
The fix: a new
publisherLabelhelper inscripts/timeseries-csv.tsreturns the short name, or the full name where there is none. Bothpublisherandsourceuse it. It's the same rule the review workbook uses, so the two now match exactly.Checked:
Best merged before the first real benchmark import, so the review workbook and the imported downloads agree.
🤖 Generated with Claude Code