Skip to content

feat: re-import v2 timeseries, show geothermal as low-carbon, drop Renewables - #989

Merged
jacobvjk merged 4 commits into
epic/v2from
feat/import-benchmar-data-v2
Oct 15, 2026
Merged

jacobvjk merged 4 commits into
epic/v2from
feat/import-benchmar-data-v2

Conversation

@jacobvjk

Copy link
Copy Markdown
Collaborator

Re-imports the v2 timeseries from the prep repo, and fixes two things the new data showed up. The three commits pass on their own, so it can be reviewed commit by commit.

Review tip: the data commit is ~75k lines of generated JSON, so skim it. The other two commits are small.

1. Timeseries import (ba28d3f)

From the prep repo's main, after RMI/tpr_benchmark_data_preparation#21 stopped publishing IEA's Renewables total.

Files Change
IEA 2024 ×3 Renewables total removed; geothermal and energy storage added
ACE ×4, UTS-ISF Geothermal added
TransitionZero ×4 Geothermal and energy storage added
JETP CIPP Geothermal, energy storage and a new technology mix series. "Other" drops sharply (2050 generation 250.8 → 81.4 TWh) because those two used to sit inside it.
JRC GECO ×3 Same rows; values carry one more decimal place (e.g. 77 → 77.4)
UN SDSN / ClimateWorks 6 new files: Myanmar ×3, Thailand ×3. Their pathways are on v2, so they show on the site.

Every region in the new data is declared in its pathway's metadata, so this adds nothing to #971.

Worth a look in the preview: JETP's new technology mix chart.

2. Geothermal in the technology mix chart (3993768)

The chart had no colour for geothermal, so it was drawn black and sorted to the bottom of the stack next to coal, reading as high-carbon. It now sits in the low-carbon blues between biofuels and hydro (rmiblue-400). A new test fails if any Power technology that can appear in the mix has no colour.

3. Renewables is no longer a Power technology (69a7833)

Renewables is the total of other Power technologies, so listing it next to them double-counts. Cookbook decision 0020 removed it, and #858 kept it only while removing it would break data. Now that the prep repo no longer publishes it:

  • Timeseries v2 schema: removed from both technology lists. v1 keeps it.
  • Taxonomy: removed from Power, so v2 metadata rejects it as a technology and as a data availability granularity value.
  • Metadata: removed from 9 Power technology lists (IEA, JRC GECO) and 30 granularity entries (ACE, IEA 2025, SDSN-CW Laos). Every affected row keeps its other values.
  • technology.v1.json: the comment now says why Renewables belongs to no sector. It had read as though it was already removed.
  • Methodology page: the Power list drops renewables and adds geothermal and energy storage, which were missing.

Needed outside this repo: remove "Renewables" from the data availability granularity of these 17 pathways in pathway_data_prepared.xlsx. Otherwise the next metadata import brings it back and validation rejects it. Power technology lists need no workbook change, because the importer already drops technologies that don't belong to their sector.

Checks

  • schema:check: 90 valid, 0 invalid
  • Full test suite, ESLint and Prettier pass, at each commit and at the tip
  • build:timeseries leaves index.gen.ts unchanged
  • tsc -b --noEmit reports the same 220 errors as epic/v2 (Make the codebase type-check, and gate CI on it #972), none new

Refs #461, #858

🤖 Generated with Claude Code

jacobvjk and others added 3 commits October 12, 2026 18:12
Re-import of the prep repo's v2 output, after it stopped publishing
IEA's Renewables total as a technology (tpr_benchmark_data_preparation#21).

- Geothermal now arrives as its own series for ACE, IEA, JETP,
  TransitionZero and UTS-ISF; energy storage for IEA, JETP and
  TransitionZero. JETP's "other" shrinks accordingly and it gains a
  technology mix series.
- IEA's Renewables total rows are gone.
- JRC GECO values now carry one more decimal place.
- Six new UN SDSN / ClimateWorks timeseries (Myanmar x3, Thailand x3).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The technology mix chart had no colour for geothermal, so it was drawn
in the default black and sorted to the bottom of the stack next to coal,
reading as a high-carbon technology. It now sits among the low-carbon
blues, between biofuels and hydro, using rmiblue-400.

A test checks that every Power technology in the taxonomy that can
appear in the technology mix has a colour, so the next new technology
cannot fall through the same way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Renewables is the total of other Power technologies (solar, wind, hydro
and so on), so listing it next to them double-counts. Cookbook decision
0020 removed it; #858 kept it only while removal would break data.
Now that the prep repo no longer publishes it, it goes:

- pathwayTimeseries.v2: removed from both technology lists. v1 keeps it,
  so existing v1 documents still validate.
- timeseriesTaxonomy: removed from Power, so v2 metadata rejects it as a
  sector technology and as a dataAvailability granularity value.
- Data: removed from 9 Power technology lists (IEA, JRC GECO) and 30
  dataAvailability granularity entries (ACE, IEA 2025, SDSN-CW Laos).
- technology.v1.json: the comment now says why Renewables belongs to no
  sector, which had read as though it was already gone.
- Methodology page: the Power list loses renewables and gains the
  geothermal and energy storage technologies it was missing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Expected version change and release notes

🚨 WARNING: This PR is not expected to trigger a new version

To trigger a version bump, use at least one conventional commit message in this branch. See: https://www.conventionalcommits.org/en/v1.0.0/

@github-actions

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-989.westus2.2.azurestaticapps.net

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Generated timeseries expose floating-point artifacts and false precision that should be corrected before publication.

1 open finding
What changed in this PR

Re-imports v2 power timeseries, removes the double-counted Renewables aggregate, and renders geothermal as low-carbon.

Changes:

  • Refreshes 22 timeseries datasets and adds six Myanmar/Thailand series.
  • Removes Renewables from v2 schemas, taxonomy, metadata, and documentation.
  • Adds geothermal chart styling and taxonomy coverage testing.
File Description
src/​utils/​validateScopes.test.ts Tests Renewables rejection.
src/​utils/​timeseriesTaxonomy.ts Removes Renewables taxonomy entry.
src/​utils/​timeseriesTaxonomy.test.ts Updates Power taxonomy expectations.
src/​types/​pathwayTimeseries.v2.d.ts Removes Renewables from v2 type.
src/​schema/​pathwayTimeseries.v2.json Removes Renewables from v2 enums.
src/​schema/​common/​technology.v1.json Clarifies v1 compatibility.
src/​pages/​resources/​ResourcesMethodologyPage.tsx Updates Power technology documentation.
src/​components/​NormalizedStackedAreaChart.tsx Adds geothermal styling.
src/​components/​NormalizedStackedAreaChart.test.ts Checks chart color coverage.
src/​data/​index.gen.ts Refreshes the timeseries index.
src/​data/​uts-isf/​UTS-ISF-OECM-2024_timeseries.json Refreshes UTS-ISF data.
src/​data/​iea/​IEA-APS-2024_timeseries.json Refreshes IEA APS data.
src/​data/​iea/​IEA-NZE-2024_timeseries.json Refreshes IEA NZE data.
src/​data/​iea/​IEA-STEPS-2024_timeseries.json Refreshes IEA STEPS data.
src/​data/​asean-centre-for-energy/​ATS-2024_timeseries.json Refreshes ACE ATS data.
src/​data/​asean-centre-for-energy/​BAS-2024_timeseries.json Refreshes ACE BAS data.
src/​data/​asean-centre-for-energy/​CNS-2024_timeseries.json Refreshes ACE CNS data.
src/​data/​asean-centre-for-energy/​RAS-2024_timeseries.json Refreshes ACE RAS data.
src/​data/​transitionzero/​TZ-BAU-2024_timeseries.json Refreshes TransitionZero BAU data.
src/​data/​transitionzero/​TZ-EBAU-2024_timeseries.json Refreshes TransitionZero EBAU data.
src/​data/​transitionzero/​TZ-ISG-2024_timeseries.json Refreshes TransitionZero ISG data.
src/​data/​transitionzero/​TZ-REGI-2024_timeseries.json Refreshes TransitionZero REGI data.
src/​data/​jetp-id/​JETP-CIPP-2023_timeseries.json Adds technology-mix detail.
src/​data/​jrc/​JRC-GECO-1-5-2025_timeseries.json Refreshes GECO 1.5°C data.
src/​data/​jrc/​JRC-GECO-NDC-LTS-2025_timeseries.json Refreshes GECO NDC-LTS data.
src/​data/​jrc/​JRC-GECO-REFERENCE-2025_timeseries.json Refreshes GECO reference data.
src/​data/​un-sdsn-cw/​UNSDSN-CW-EPP-MM-2025_timeseries.json Adds Myanmar EPP data.
src/​data/​un-sdsn-cw/​UNSDSN-CW-OEPP-MM-2025_timeseries.json Adds Myanmar OEPP data.
src/​data/​un-sdsn-cw/​UNSDSN-CW-OMAP-MM-2025_timeseries.json Adds Myanmar OMAP data.
src/​data/​un-sdsn-cw/​UNSDSN-CW-EXT-TH-2024_timeseries.json Adds Thailand EXT data.
src/​data/​un-sdsn-cw/​UNSDSN-CW-MAP-TH-2024_timeseries.json Adds Thailand MAP data.
src/​data/​un-sdsn-cw/​UNSDSN-CW-NZE-TH-2024_timeseries.json Adds Thailand NZE data.
src/​data/​iea/​IEA-APS-2024.json Removes Renewables metadata.
src/​data/​iea/​IEA-NZE-2024.json Removes Renewables metadata.
src/​data/​iea/​IEA-STEPS-2024.json Removes Renewables metadata.
src/​data/​iea/​IEA-CPS-2025.json Removes Renewables metadata.
src/​data/​iea/​IEA-NZE-2025.json Removes Renewables metadata.
src/​data/​iea/​IEA-STEPS-2025.json Removes Renewables metadata.
src/​data/​jrc/​JRC-GECO-1-5-2025.json Removes Renewables metadata.
src/​data/​jrc/​JRC-GECO-NDC-LTS-2025.json Removes Renewables metadata.
src/​data/​jrc/​JRC-GECO-REFERENCE-2025.json Removes Renewables metadata.
src/​data/​asean-centre-for-energy/​ACE-ATS-2024.json Removes Renewables granularity.
src/​data/​asean-centre-for-energy/​ACE-BAS-2024.json Removes Renewables granularity.
src/​data/​asean-centre-for-energy/​ACE-CNS-2024.json Removes Renewables granularity.
src/​data/​asean-centre-for-energy/​ACE-RAS-2024.json Removes Renewables granularity.
src/​data/​un-sdsn-cw/​SDSN-CW-EP-LA-2025.json Removes Renewables granularity.
src/​data/​un-sdsn-cw/​SDSN-CW-MAP-LA-2025.json Removes Renewables granularity.
src/​data/​un-sdsn-cw/​SDSN-CW-OEP-LA-2025.json Removes Renewables granularity.
src/​data/​un-sdsn-cw/​SDSN-CW-OMAP-LA-2025.json Removes Renewables granularity.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/data/asean-centre-for-energy/RAS-2024_timeseries.json Outdated
@github-actions

Copy link
Copy Markdown

Expected version change and release notes

🚨 WARNING: This PR is not expected to trigger a new version

To trigger a version bump, use at least one conventional commit message in this branch. See: https://www.conventionalcommits.org/en/v1.0.0/

@github-actions

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-989.westus2.2.azurestaticapps.net

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The broad generated-data refresh and externally sourced numerical changes require final human provenance and preview verification.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

@jacobvjk
jacobvjk merged commit 281861e into epic/v2 Oct 15, 2026
11 checks passed
@jacobvjk
jacobvjk deleted the feat/import-benchmar-data-v2 branch October 15, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants