[ROCM-28806] Remove Navi4x guard for gemm_tune_invalid_sol_index - #5174
Draft
eddieliao wants to merge 1 commit into
Draft
[ROCM-28806] Remove Navi4x guard for gemm_tune_invalid_sol_index#5174eddieliao wants to merge 1 commit into
eddieliao wants to merge 1 commit into
Conversation
eddieliao
added
the
Changelog: Not Applicable
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the obsolete Navi4x guard so the GEMM invalid solution-index test runs with restored rocBLAS support.
Changes:
- Removed the unused device-name include.
- Removed the gfx1201-specific skip and stale TODO.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
This requires the version of rocBLAS inside the CI image to be updated, moving to draft until ready. |
eddieliao
marked this pull request as draft
August 24, 2026 21:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Removes guard now that rocBLAS has restored existing functionality.
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot ApplicableFollow the LLVM AI Tool Use Policy for contributions using AI.