Disable subprocess spawning during hiprtc kernel compilation - #5189
Open
pnikolic-amd wants to merge 9 commits into
Open
Disable subprocess spawning during hiprtc kernel compilation#5189pnikolic-amd wants to merge 9 commits into
pnikolic-amd wants to merge 9 commits into
Conversation
Collaborator
|
Can this be a cmake option instead? |
Regressions detected 🔴 * No develop baseline was found for this PR's branch point; compared against the latest available develop run instead. |
|
Collaborator
Author
@pfultz2 We want to have option to change behavior in with api option so it can be modified for specific environment in runtime. We don't want to have specific build. |
Collaborator
What does "specific environment" mean here? This still sounds global which means we dont need a backend option, we could use an env variable or just delete the hiprtc driver for that environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This option is introduced to prevent migraphx to create processes and write to files while comping kernels with hiprtc. Some use cases prevent use of processes so that why this option is introduced. When set kernel compilation will be done sequentially which will result in slower compilation time.
Technical Details
This option can be set using backend_options field in compile_options struct. Example: