Skip to content

[Bugfix][Benchmark] Fix compiler API usage in Softmax and RMSNorm benchmarks - #1108

Open
tangzzycc wants to merge 1 commit into
ROCm:mainfrom
tangzzycc:fix/benchmark-compiler-api
Open

tangzzycc wants to merge 1 commit into
ROCm:mainfrom
tangzzycc:fix/benchmark-compiler-api

Conversation

@tangzzycc

Copy link
Copy Markdown

Motivation

The shared comparison sweep does not report FlyDSL timing results for Softmax and RMSNorm.

Both paths call the removed top-level flydsl.compile API. The resulting AttributeError is caught by run_compare_sweep, which records flydsl_gpu_us=None, so the failure appears as a missing - result instead of an explicit error.

Technical Details

  • Import flydsl.compiler as flyc.
  • Use flyc.compile for the Softmax and RMSNorm benchmark paths.
  • Reuse the same compiler import in the LayerNorm path.

Test Plan

Test Result

Submission Checklist

Signed-off-by: tangzzycc <3081129260@qq.com>
Copilot AI lite review requested due to automatic review settings September 9, 2026 03:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a narrow, verified API-call fix in benchmark code that aligns with the existing flydsl.compiler.compile export surface and removes the known failure mode.

Pull request overview

Fixes FlyDSL benchmark timing gaps for Softmax and RMSNorm by updating the benchmarks to use the current compiler entry point (flydsl.compiler.compile) instead of the removed top-level flydsl.compile, preventing silent AttributeError-driven “missing result” reporting in the comparison sweep.

Changes:

  • Switch Softmax and RMSNorm benchmark compilation from flydsl.compile(...) to flydsl.compiler.compile(...) (imported as flyc.compile(...)).
  • Reuse the same flydsl.compiler as flyc import across Softmax, LayerNorm, and RMSNorm paths.
  • Update the docstring to reflect the new API usage.
File summaries
File Description
tests/kernels/benchmark_common.py Updates benchmark compilation calls to the supported flydsl.compiler.compile API so Softmax/RMSNorm timings are reported correctly.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants