Repository navigation
Conversation
Signed-off-by: tangzzycc <3081129260@qq.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a narrow, verified API-call fix in benchmark code that aligns with the existing flydsl.compiler.compile export surface and removes the known failure mode.
Pull request overview
Fixes FlyDSL benchmark timing gaps for Softmax and RMSNorm by updating the benchmarks to use the current compiler entry point (flydsl.compiler.compile) instead of the removed top-level flydsl.compile, preventing silent AttributeError-driven “missing result” reporting in the comparison sweep.
Changes:
- Switch Softmax and RMSNorm benchmark compilation from
flydsl.compile(...)toflydsl.compiler.compile(...)(imported asflyc.compile(...)). - Reuse the same
flydsl.compiler as flycimport across Softmax, LayerNorm, and RMSNorm paths. - Update the docstring to reflect the new API usage.
File summaries
| File | Description |
|---|---|
| tests/kernels/benchmark_common.py | Updates benchmark compilation calls to the supported flydsl.compiler.compile API so Softmax/RMSNorm timings are reported correctly. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The shared comparison sweep does not report FlyDSL timing results for Softmax and RMSNorm.
Both paths call the removed top-level
flydsl.compileAPI. The resultingAttributeErroris caught byrun_compare_sweep, which recordsflydsl_gpu_us=None, so the failure appears as a missing-result instead of an explicit error.Technical Details
flydsl.compilerasflyc.flyc.compilefor the Softmax and RMSNorm benchmark paths.Test Plan
Test Result
Submission Checklist