Repository navigation
[Skills] Add deterministic preflight to the review runner - #1124
Merged
jhinpan merged 1 commit intoSep 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets #1106's
add-flydsl-code-review-skillbranch. It distills the two useful deterministic checks from #1047 into the existing review runner, so #1106 carries the combined review capability intomain.The pinned diff is scanned for added kernel legacy-API spellings and added tests without a statically visible script entry path. Raw observations go to Angles G and I for contextual adjudication; promoted candidates retain the existing independent verifier, challenger, and ranked-report path. Both preflight stages are checkpointed and required: exit 0/1 permits semantic review, while errors/timeouts yield
INCOMPLETE. Scanner implementation changes invalidate resume, and the saved diff is checked against the pinned hash. Artifact schema v2 requires valid preflight outputs before publication.The source scanners and 38 original regressions are adapted from #1047 at
2480f877aa7f74a24d1ce857b48ba92ff0699cf5. The integration also fixes four reproduced scanner edge cases: Python 3.12 f-string literal false positives, unconsumed generator expressions, pattern-match shadowing, and rebound pytest test functions/classes/methods. The selection evidence stays linked to the source revision; no second review skill or combined standalone wrapper is added.This also fixes #1106's remaining CLI compatibility finding: verbose Claude Code output can be a transcript array. The runner consumes the last result record and preserves all error, permission-denial, and structured-output checks.
Validation:
verbose: truesetting: the exactcli_agentinvocation returned an array-shaped transcript and completed successfully.7e117e29c9c4582158aed33da4ee6dfe14d2c76e: the entry-path scanner finds the three omitted fused/quant tests at lines 632, 884, and 924.scripts/check_repo.py, whole-tree agent-doc validation, the repository Python style gate, and explicit black/ruff checks on the skill scripts passed.These checks establish scanner and runner behavior. Full model-review corpus precision/recall and GPU execution were not measured. The existing per-angle candidate limit remains; raw scanner leads are preserved, not individually certified. Standard repository CI is configured for PRs targeting
main, so the combined branch will run that CI through #1106 after this child PR merges.