Skip to content

feat(review): harden review engine for unattended runs - #1157

Open
jhinpan wants to merge 6 commits into
add-flydsl-code-review-skillfrom
feat/review-engine-hardening
Open

jhinpan wants to merge 6 commits into
add-flydsl-code-review-skillfrom
feat/review-engine-hardening

Conversation

@jhinpan

@jhinpan jhinpan commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator

Stacked on #1106. This layer hardens only the review engine contract for unattended execution: trusted offline PR scope manifests, schema-bound repository/author identity, trusted-policy prompt resolution, explicit environment and filesystem/network sandboxing, and publisher checks for implementation, account, draft/head identity, and sanitized output.

It also adds opt-in --group-finders: all nine checklists share one source-reading session while structured coverage, per-candidate owning angles, per-angle limits, independent verification, and deterministic provenance remain enforced. The default remains nine independent finders. In the untrusted profile, model sessions receive only Read, Grep, and Glob and consume the pinned diff.patch; reviewed-tree Bash/code execution is unavailable.

On frozen PR #1137, the schema-v6 grouped finder completed in 648.71 seconds for $3.57 with all nine coverage labels, five candidates, zero denials, and no limitations. It does not add a watcher or deployment service; those remain isolated in the next stack layer.

Signed-off-by: jhinpan <47354855+jhinpan@users.noreply.github.com>
Signed-off-by: jhinpan <47354855+jhinpan@users.noreply.github.com>
* feat(review): add local coderfeli review watcher

Signed-off-by: jhinpan <47354855+jhinpan@users.noreply.github.com>

* fix(review): fetch pinned engine commit from origin

Signed-off-by: jhinpan <47354855+jhinpan@users.noreply.github.com>

* fix(review): budget Opus finder phase for pilot

Signed-off-by: jhinpan <47354855+jhinpan@users.noreply.github.com>

* fix(review): use Docker init for review workers

Signed-off-by: jhinpan <47354855+jhinpan@users.noreply.github.com>

* perf(review): batch finder angles in local watcher

---------

Signed-off-by: jhinpan <47354855+jhinpan@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant