Repository navigation
Revert "Refactor preshuffle GEMM indexing with layout algebra (#1131)" - #1189
Merged
Merged
Conversation
This reverts commit e70bf79. The new DMA layout computes rows_per_wave = 64 // (tile_k_bytes // 16), which is 0 when an A row exceeds 1024 bytes (fp16/bf16 with tile_k=1024, exercised by the 2-wave tiles added in #1183), producing wrong results on gfx950 (test_mfma_a8_flyc_preshuffle[fp16-*-tile*x32x1024-async-eager]). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #1131 (e70bf79), which broke main CI on MI35x (run):