[GPUOP-1033] gpuagent: sentinel for unsupported video/data clock min/max - #90
Merged
sarat-k merged 1 commit intoAug 26, 2026
Merged
Conversation
amdsmi_get_clock_info returns NOT_SUPPORTED for VCLK0/DCLK0 min/max on MI210. The error branch previously left the zero-initialized clock_spec lo/hi at 0, which the exporter treats as a real value and emits. Set AMDSMI_INVALID_UINT32 on error so the exporter's IsValueApplicable gate suppresses the metric instead of exporting a misleading 0. Guard deep_sleep against the sentinel min frequency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amdsmi_get_clock_info returns NOT_SUPPORTED for VCLK0/DCLK0 min/max on MI210. The error branch previously left the zero-initialized clock_spec lo/hi at 0, which the exporter treats as a real value and emits. Set AMDSMI_INVALID_UINT32 on error so the exporter's IsValueApplicable gate suppresses the metric instead of exporting a misleading 0. Guard deep_sleep against the sentinel min frequency.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist