Repository navigation
Add Claude skills tooling, prepare for CRAN, and clean up repo - #13
Merged
Merged
Conversation
* DESCRIPTION: add copyright holder (RTI International) to Authors@R; expand Description field to spell out SRS/PPS on first use * serp_sort(): add missing @examples (required for CRAN, was the only exported function without them); regenerate man/ and NAMESPACE * README: add install.packages("SampleSelectR") instructions ahead of the GitHub dev-install steps * Add cran-comments.md documenting a clean R CMD check --as-cran run (0 errors, 0 warnings, 0 notes)
Add .githooks/pre-commit (usethis's standard README hook), which blocks a commit when README.Rmd is newer than README.md or when only one of the pair is staged. Hooks in .git/hooks aren't tracked by git, so the script lives in a committed .githooks/ directory instead; document the one-time `git config core.hooksPath .githooks` setup step in README so collaborators pick it up after cloning. Also includes an incidental re-knit of README.md (the proportional allocation example's tie-break output shifted slightly on rebuild; worth a look separately since the seed is fixed).
* man/figures/README-pressure-1.png: leftover plot from the default Rmd template's "pressure" example chunk; current README.Rmd has no such chunk * data-raw/IPEDS_2023/flags2023.xlsx: only flags2023.csv is read by ipeds.Rmd * .github/install_package.R: not referenced by any GitHub Actions workflow
szimmer
changed the title
A stray \cr immediately after \enumerate{}'s closing brace in the
`outputs` @PARAM docs produced a bare \ in the generated LaTeX with no
open paragraph to break, causing 'LaTeX Error: There's no line here to
end.' and failing devtools::build_manual() / R CMD Rd2pdf.
* Sampling_Output(): switch cat() to message() so the per-stratum
sampling summary can be silenced with suppressMessages(). Writing to
the console with cat() is one of the most common first-submission
rejections ("please use message()/warning() or if(verbose)cat()");
all four samplers -- srs(), sys(), sys_pps(), chromy_pps() -- printed
unconditionally with no way to turn it off.
* DESCRIPTION: add method references in the form CRAN asks for, Kalton
(1983) <doi:10.4135/9781412984683> and Chromy (1979) linked to the
ASA proceedings PDF. Both were already cited in the man pages, and
CRAN routinely asks for them in the Description field. The Chromy
link stays on http because www.asasrms.org does not present a valid
TLS certificate; the http URL resolves without redirect.
* Replace @Keywords internal with @nord on the seven unexported
helpers (check_frame_type, check_n, check_outall, check_string_mos,
Sampling_Output, chromy_inner, create_group_variable). They were
shipping man pages into the PDF manual and pkgdown reference, which
also leaves an opening for a reviewer to ask for @examples on
internal functions. Nothing cross-referenced them.
* Sampling_Output(): add the missing blank roxygen line that was
collapsing the title and description into a two-sentence \title{}.
* cran-comments.md: report the 1 expected "New submission" NOTE rather
than 0 notes, document the http URL rationale, and reflow to soft
wrap.
* .githooks/pre-commit: only require README.Rmd and README.md to be
staged together when README.Rmd is itself staged. Re-knitting after
the message() change above updates README.md alone, which the hook
was rejecting. Staging README.Rmd without README.md still fails,
since that means the re-knit is missing.
Verified with devtools::check(manual = TRUE, cran = TRUE, "--as-cran"):
0 errors, 0 warnings, 0 notes. Also checked with
_R_CHECK_CRAN_INCOMING_=TRUE, where the only NOTEs are "New submission"
and the local absence of pandoc.
Incidental: regenerating docs migrated the generated files from
roxygen2 7.3.3 to the installed 8.1.0. That rewrites NAMESPACE's
importFrom() calls into multi-line form, replaces RoxygenNote with
Config/roxygen2/version, and adds the maintainer to the Authors list in
the package Rd (7.3.3 had been omitting them). README.md is re-knit;
the sampling interval and random start now print at full precision
because message() does not apply getOption("digits") the way cat() did.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
szimmer
marked this pull request as ready for review
August 31, 2026 16:52
biasow38-rgb
approved these changes
Sep 1, 2026
biasow38-rgb
left a comment
biasow38-rgb
left a comment
Collaborator
There was a problem hiding this comment.
I reviewed and tested the changes locally. The package built and installed successfully, all tests and examples passed, and the updated serp_sort() and suppressible Sampling_Output() behavior worked as expected. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
r-libClaude Code skills plugin (.claude/settings.json)[cph](copyright holder) role for RTI International inAuthors@RDescriptionfield to spell out SRS/PPS on first use@examplestoserp_sort()(the only exported function without them)install.packages("SampleSelectR")instructions to the READMEcran-comments.mddocumenting a cleanR CMD check --as-cranrun (0 errors, 0 warnings, 0 notes)pre-commithook (.githooks/pre-commit) that keepsREADME.mdin sync withREADME.Rmd; document the one-timegit config core.hooksPath .githookssetup step for collaboratorsman/figures/README-pressure-1.png,data-raw/IPEDS_2023/flags2023.xlsx, and.github/install_package.RTest plan
devtools::check(cran = TRUE)passes with 0 errors, 0 warnings, 0 notesurlchecker::url_check()passesdevtools::build_readme()re-knits cleanly and matches the committedREADME.mdREADME.Rmd/README.mdis staged