Repository navigation
Orphan reaper: recognise Proxmox's real missing-VM response - #72
Merged
Merged
Conversation
PVE answers a request for a missing guest with HTTP 500 and "... does not exist", not 404, so the reaper reported stop/delete failures for guests that had already vanished. Use the app's standard check: the error must look like absence and a fresh inventory must agree. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proxmox returns HTTP 500 with "Configuration file ... does not exist" for a missing guest, not 404 (verified on a live cluster). The reaper only accepted 404, so a guest that vanished between inventory and stop/delete was logged as a failure.
The reaper now uses the same check as the destroy paths:
confirm_proxmox_absence, i.e. the error must look like absence and a fresh inventory must agree. An absence-like error while inventory still lists the guest stays a failure (safe).Tests (red first): the real 500 shape on stop and on delete reports
not_found; the same message with the guest still in inventory staysstop_failed; a transport error mentioning 404 in its URL staysstop_failed.