Repository navigation
Deploy docs: authenticated check must pick an enabled admin - #75
Merged
Merged
Conversation
A disabled admin (e.g. the built-in admin account once disabled) is correctly refused with 401, which made the documented post-deploy check look like a failed deploy. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The post-deploy authenticated check in
docs/PRODUCTION_DEPLOYMENT.mdpickedUser.query.filter_by(is_admin=True).first(). On a host where the built-inadminaccount is disabled (as recommended), that returns the disabled account, which is correctly refused with 401, so the check reports a failed deploy that isn't one. It now selects an enabled admin.Verified on the production deploy of
c617a9e: the old snippet gave_diag 401 / list 401; the corrected snippet, run verbatim, gives_diag 200 / list 200. Docs only.