Repository navigation
fix(cli): validate invocations and route Cobra output through term.W - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid flags returned runtime-error exit code 1, and unexpected positional arguments could silently create a tag. Cobra help and version output also bypassed the configured terminal writer.
Classify flag and positional-argument errors as configuration errors with exit code 2. Reject extra arguments before Git operations for bump, status, and suggest. Resolve term.W for every Cobra output write so swapping the writer captures help and version output. Runtime failures still exit with code 1.
Closes #10
Closes #11
Closes #17
Validation: regression tests failed on the original implementation and now pass. Subprocess tests check actual exit codes, argument tests assert no Git operations, and output tests replace term.W repeatedly.
go test ./...,go vet ./..., and golangci-lint v2.13.0 pass.