Skip to content

Fix list block colour in instructions - #1662

Merged
zetter-rpf merged 2 commits into
mainfrom
fix-list-block-type
Sep 25, 2026
Merged

zetter-rpf merged 2 commits into
mainfrom
fix-list-block-type

Conversation

@zetter-rpf

Copy link
Copy Markdown
Contributor

Closes: https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/1832

  • Add missing list mapping so list blocks display in the right colour
  • Add fallback background colour so blocks are readable if mapping is missing or block type is incorrect

See commits for more


For the markdown:

`list block`{:block-type="lists"} 

`not a block`{:block-type="lissst"} 

Now shows:
Screenshot 2026-09-25 at 12 24 00

This meant the blocks had a dark grey background instead of the lovely peachy-coral.
Previously if the block type wasn't defined correctly or you had made a typo the block would be hard to read as it would use a dark text on a dark background. Give a default background that is readable.
@zetter-rpf zetter-rpf changed the title Fix list block type Fix list block type color Sep 25, 2026
@zetter-rpf zetter-rpf changed the title Fix list block type color Fix list block type colour Sep 25, 2026
@zetter-rpf
zetter-rpf marked this pull request as ready for review September 25, 2026 11:25
@zetter-rpf zetter-rpf changed the title Fix list block type colour Fix list block colour in instructions Sep 25, 2026
@maxelkins
maxelkins self-requested a review September 25, 2026 13:28

@maxelkins maxelkins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@zetter-rpf
zetter-rpf merged commit c813c22 into main Sep 25, 2026
11 checks passed
@zetter-rpf
zetter-rpf deleted the fix-list-block-type branch September 25, 2026 15:28

This branch was successfully deployed

1 active deployment
previews/1662/merge — 16d045b4 Deployed Sep 25, 2026 by zetter-rpf via deploy-branch / build-deploy #6820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants