Preserve imported words and bound speech download lifetimes - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing a replacement for a bundled word appeared to succeed, but the following home refresh wrote the sample back over it. Sample initialization now inserts missing meanings without changing existing content or progress. Imports accept one S6 object or an array, validate all entries before writing, and enforce the bytes actually read. Import results and refresh failures are separate UI states, so a retry clears the loading error while preserving committed counts.
Speech downloads previously reset their timeout for every received chunk. One deadline now covers headers and the entire body; expiry aborts the request, cancels body consumption and closes its owned client. This change also raises the declared http minimum to the already-locked 1.6.0 API used for cancellation.
Validation: Flutter 3.44.0 analysis and all 93 tests passed locally. Regression tests exercise actual home imports, automatic refresh, retry and a partial SQLite write failure, plus slow and malformed gateway responses. Public-tree and redacted Gitleaks history/staged checks passed. CI checks Flutter 3.44.0 and 3.47.2, with an Android debug build and downloadable artifact on 3.47.2.
The committed lockfile was resolved with Flutter 3.44.0; seven framework/test dependencies therefore match that SDK's pins. The newer CI SDK resolves its required framework pins separately. These changes are not claimed as http security upgrades. APKs are development builds, not signed store releases. Gateway tests inject the HTTP transport; they do not constitute a network soak test.