Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
73a64c2
Add procedures for processing unit-level PSH supply curves
jvcarag Jul 29, 2026
77f512a
Merge branch 'main' into vc/UnitLevelPSHSC
jvcarag Jul 30, 2026
e24e60c
Delete unit adjustment for PSH supply curve costs
jvcarag Aug 4, 2026
44fb621
Remove copy keyword from reindex function call (deprecated in Pandas …
jvcarag Aug 10, 2026
c2306be
Update lat/lon column names for PSH procedure in assemble_supplycurve()
jvcarag Aug 10, 2026
8184e3c
Add limited and reference 10hr PSH supply curve options, update open1…
jvcarag Aug 10, 2026
5bb3cfb
Add duration entries for new supply curves to inputs/storage/PSH_supp…
jvcarag Aug 18, 2026
899f4ee
Merge branch 'main' into vc/UnitLevelPSHSC
jvcarag Aug 24, 2026
9d76098
Update `pshsupplycurve` choices formatting and default value in cases…
jvcarag Aug 24, 2026
aeaedda
Clip PSH supply curve costs above $3000/kW in 2004$
jvcarag Aug 26, 2026
d2233d5
Update new supply curve files
jvcarag Aug 26, 2026
3578a6e
Update cost cutoff for PSH supply curve sites to $4000/kW [2004$]
jvcarag Sep 3, 2026
3619177
Add reference/limited 8hr PSH supply curves
jvcarag Sep 11, 2026
82291d6
Add open 8hr PSH supply curve
jvcarag Sep 14, 2026
703efd9
Add 12hr PSH supply curves
jvcarag Sep 14, 2026
ab780e6
Clean-up:
jvcarag Sep 14, 2026
8472a3b
Remove old PSH supply curve input files and update supply curve READM…
jvcarag Sep 14, 2026
27e76b9
Set 8hr Reference case as default for PSH supply curves
jvcarag Sep 21, 2026
aefac1b
Merge branch 'main' into vc/UnitLevelPSHSC
jvcarag Sep 23, 2026
02ba4ff
Delete old PSH supply curve processing steps in writesupplycurves.py
jvcarag Sep 28, 2026
8d1a0af
Add supplycurve_psh.csv entry to futurefiles.csv and remove debug lin…
jvcarag Sep 28, 2026
fcc8bc8
Merge branch 'main' into vc/UnitLevelPSHSC
jvcarag Sep 30, 2026
c18245f
PR Cleanup:
jvcarag Sep 30, 2026
d24c29c
Merge branch 'vc/UnitLevelPSHSC' of github.com:ReEDS-Model/ReEDS into…
jvcarag Sep 30, 2026
c4221ce
Revert PSH supply curve filename format to place storage duration bef…
jvcarag Oct 2, 2026
001501c
Merge branch 'main' into vc/UnitLevelPSHSC
jvcarag Oct 7, 2026
9d281af
Addressing PR Review by @kodiobika:
jvcarag Oct 8, 2026
db170c7
Merge branch 'vc/UnitLevelPSHSC' of github.com:ReEDS-Model/ReEDS into…
jvcarag Oct 8, 2026
f66564b
Merge branch 'main' into vc/UnitLevelPSHSC
jvcarag Oct 8, 2026
cc6b9da
Remove remaining instance of spur_cutoff in writesupplycurves.py
jvcarag Oct 9, 2026
47bccb4
Revert region-level class binning change in resource.py
jvcarag Oct 9, 2026
baa8fbe
Address review by @patrickbrown4
jvcarag Oct 13, 2026
2eff241
Merge branch 'main' into vc/UnitLevelPSHSC
jvcarag Oct 14, 2026
1e032b0
Specify psh_cutoff units as a "cost per MW"
jvcarag Oct 14, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cases.csv
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ geohydrosupplycurve,Geohydro Supply Curve,ATB_2023,ATB_2023,
egssupplycurve,EGS Supply Curve,ATB_2023; reV,reV,
egsnearfieldsupplycurve,EGS (near field) Supply Curve,ATB_2023,ATB_2023,
ngscen,Natural gas price inputs (see inputs\fuelprices),N/A,AEO_2026_baseline,
pshsupplycurve,PSH Supply Curve,(8|10|12)hr_(ref|wEphemeral|wExist|wEph|wExist_wEph)_(apr2025|mar2024),12hr_ref_apr2025,
pshsupplycurve,PSH Supply Curve,(8|10|12)hr_(limited|reference|open),8hr_reference,
pvbscen,PVB cost-sharing scenario,benchmark2020,benchmark2020,
dacscen,Electrical DAC cost and performance inputs (see inputs/consume/[dacscen].csv starting with 'dac_elec_').,BVRE_2021_(high|mid|low),BVRE_2021_mid,
h2combustionfuelscen,H2-CT/CC Fuel Price Scenarios (only used if endogenous H2 production is turned off),10; reference; 30,reference,
Expand All @@ -64,12 +64,13 @@ techs_suffix,File suffix for master list of technologies,default; subsetForTesti
dollar_year,DO NOT CHANGE FROM 2004 UNTIL ALL FINANCIAL INPUTS HAVE DOLLAR YEAR ADJUSTMENT - Real dollar year for model to calculate and report,2004,2004,
sys_eval_years,Number of years that the model evaluates investments on,int,30,
numhintage,"number of hintage bins. Enter 'unit' for unit level bins. Enter 'group' to group by unique technology, region, and heatrate combinations",int,6,
numbins_windons,Number of interconnection supply curve bins for onshore wind; options are 5 and 1300 (for individual sites lite),int,10,
numbins_windons,Number of interconnection supply curve bins for onshore wind,int,10,
numbins_windofs,Number of interconnection supply curve bins for offshore wind; options are 5 and 1300 (for individual sites lite),int,5,
numbins_upv,Number of interconnection supply curve bins for upv; options are 20 and 1300 (for individual sites lite),int,40,
numbins_upv,Number of interconnection supply curve bins for upv,int,40,
numbins_csp,Number of interconnection supply curve bins for csp,int,5,
numbins_geohydro_allkm,Number of interconnection supply curve bins for hydrothermal geothermal,int,10,
numbins_egs_allkm,Number of interconnection supply curve bins for deep enhanced geothermal,int,10,
numbins_psh, Number of interconnection supply curve bins for pumped storage hydropower,int,15,
mindev,minimum deviation for a hintage to qualify for a new bin,int,50,
unitdata,"Unit Database: ""EIA-NEMS"" for NEMS",EIA-NEMS,EIA-NEMS,
marg_vre_mw,MW for marginal VRE curt/cc calcs,N/A,1000,
Expand Down Expand Up @@ -322,6 +323,7 @@ GSw_StateRPS_Carveouts,Turn wind and solar carveouts off/on,0;1,0,
GSw_StateCO2ImportLevel,Hierarchy level within which to calculate CO2 emissions rate [metric ton/MWh] for state CO2 caps,r; nercr; transreg; cendiv; st; interconnect; country; usda_region,interconnect,
GSw_Storage,0=ban storage; 1=use all standalone storage techs,0; 1,1,
GSw_StorageBinPenalty,Turn on/off the storage bin penalty for the PRM method (when on results in better firm capacity outputs),0; 1,1,
GSw_TechCostAdjust,"Fractional adjustments to overnight capital costs by technology group and year (inputs/plant_characteristics/tech_cost_adjustments_{GSw_TechCostAdjust}.csv). Groups are column names in inputs/tech-subset-table.csv; 'none' applies no adjustment",none; ATB_2025,none,
GSw_TCPhaseout,Switch for whether tax credit Phaseout is enabled (0=no; 1=yes),0; 1,1,
GSw_TCPhaseout_forceyear,(0=off by default) Indicate a year in which to force the start of the tax credit phaseout,N/A,2032,
GSw_TCPhaseout_ref_year,The reference year used to determine whether the trigger for the tax credit phaseout threshold has been hit (with 100by),N/A,2022,
Expand Down
2 changes: 1 addition & 1 deletion helpers/runstatus.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def get_run_status(reeds_path, batch_name):
mem_eff = result['Memory Efficiency'].split('%')[0]
msg = f"{duration:>10} | {cpu_eff:>5}% CPU | {mem_eff:>5}% memory ({mem_use})"
if include_finished:
print(f"{case:<{longest}}: {msg}")
print(f"{case:<{longest+1}}: {msg}")
Comment thread
kodiobika marked this conversation as resolved.
else:
### Get last .lst file
lstfiles = sorted(glob(os.path.join(fullcase,'lstfiles','*')))
Expand Down
33 changes: 9 additions & 24 deletions inputs/storage/PSH_supply_curves_durations.csv
Original file line number Diff line number Diff line change
@@ -1,25 +1,10 @@
pshsupplycurve,duration
8hr_ref_mar2024,8
Comment thread
jvcarag marked this conversation as resolved.
8hr_wEphemeral_mar2024,8
10hr_ref_mar2024,10
10hr_wEphemeral_mar2024,10
12hr_ref_mar2024,12
12hr_wEphemeral_mar2024,12
8hr_wExist_mar2024,8
8hr_wExist_wEph_mar2024,8
10hr_wExist_mar2024,10
10hr_wExist_wEph_mar2024,10
12hr_wExist_mar2024,12
12hr_wExist_wEph_mar2024,12
8hr_ref_apr2025,8
8hr_wEph_apr2025,8
10hr_ref_apr2025,10
10hr_wEph_apr2025,10
12hr_ref_apr2025,12
12hr_wEph_apr2025,12
8hr_wExist_apr2025,8
8hr_wExist_wEph_apr2025,8
10hr_wExist_apr2025,10
10hr_wExist_wEph_apr2025,10
12hr_wExist_apr2025,12
12hr_wExist_wEph_apr2025,12
8hr_limited,8
8hr_reference,8
8hr_open,8
10hr_limited,10
10hr_reference,10
10hr_open,10
12hr_limited,12
12hr_reference,12
12hr_open,12
2 changes: 1 addition & 1 deletion inputs/storage/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

- `cap_existing_psh.csv`: County-wide PSH operational capacity [MW/MWh], pump capacity, and max energy, based on plant-level data from [https://www.hydropower.org/hydropower-pumped-storage-tool](https://www.hydropower.org/hydropower-pumped-storage-tool)

- `PSH_supply_curves_durations.csv`:
- `PSH_supply_curves_durations.csv`: PSH storage duration corresponding to each PSH supply curve, used to define the storage duration of new PSH capacity as well as existing PSH capacity if not explicitly defined.

- `storage_duration.csv`:

This file was deleted.

This file was deleted.

Loading
Loading