Repository navigation
Fix Monte Carlo random sampling for VRE siting availability #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c2e11c3
b7c7ae8
ed241a2
79f333d
8c05a10
76df0c1
d86316b
cbdf8a3
23df9a4
c54435e
4730cd5
7216908
81878eb
d22bf6b
26953f0
b0bde73
0bf9f13
0fd65ae
b004682
a7068c5
7530134
77ae3ea
e82daa1
6c1f97d
0c55e25
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| ,Default Value,Pacific,USA_defaults,Mid_Case,USA_decarb,github_Pacific,github_Everything,github_MA_county_CC,Pacific_CC,Pacific_weks,Pacific_full_year,Interday_storage,Pacific_2020,Pacific_rep15,WY_county,WECC_county,PJM_county_CC,NYVT_mixed,OR_water,MonteCarlo_Random,MonteCarlo_LHS,Everything,Simple,USA_fast,USA_faster,MultiMetricRA,Pacific_DR,Pacific_MGA,Pacific_MGA_RV,Pacific_LoadSite95,MARICTNYNJPAOH_Offshore,R2P | ||
| ignore,1,0,,,,,,,,,,,,,,,,,,,,,,,,,,,,,, | ||
| GSw_Region,cendiv/Pacific,,country/USA,country/USA,country/USA,,st/ID.WY.NE.IA.IL,st/MA,,,,,,,st/WY,interconnect/western,transreg/PJM,st/NY.VT,st/OR,st/NE.NY.PA,st/NE.NY.PA,st/ID.WY.NE.IA.IL,st/KS,country/USA,country/USA,st/NY.NJ,,,,,st/MA.RI.CT.NY.NJ.PA.OH, | ||
| GSw_Region,cendiv/Pacific,,country/USA,country/USA,country/USA,,st/ID.WY.NE.IA.IL,st/MA,,,,,,,st/WY,interconnect/western,transreg/PJM,st/NY.VT,st/OR,,,st/ID.WY.NE.IA.IL,st/KS,country/USA,country/USA,st/NY.NJ,,,,,st/MA.RI.CT.NY.NJ.PA.OH, | ||
| endyear,2035,,2050,2050,2050,2030,2060,2030,,,,,,,,,,,2035,2030,2030,2060,2035,2050,2050,2050,,,,,, | ||
| yearset,,,,,,,2010..2060..10,,,,,,,,,,,,,,,2010..2060..10,2010_2015_2020..2050..3,,2010_2025_2050,,,,,,, | ||
| GSw_ZoneSet,,,,,,,z54,z3109,,,,,,,z3109,z3109,z3109,PJMcounty,,,,z54,z134,z54,z48,,,,,,, | ||
|
|
@@ -30,7 +30,7 @@ GSw_WaterUse,,,,,,,,,,,,,,,,,,,1,,,,,,,,,,,,, | |
| resource_adequacy_years,,,,,,,2011_2012_2013_2021_2022_2023,,,,,,,,,,,,,,,2011_2012_2013_2021_2022_2023,,,,,,,,,, | ||
| GSw_HourlyClusterAlgorithm,,,,,,,,,,,,,,,,,,,,user,user,,,,,,,,,,, | ||
| MCS_runs,,,,,,,,,,,,,,,,,,,,2,2,,,,,,,,,,, | ||
| MCS_dist_groups,,,,,,,,,,,,,,,,,,,,tech.hydro.nuclear.gas.coal.load_country,upv_tri.nuclear_tri.ng_fuel_price_tri.load_country_unif,,,,,,,,,,, | ||
| MCS_dist_groups,,,,,,,,,,,,,,,,,,,,load_flat_state.gasprice_flat.siting_flat_state.upv.onswind.ofswind.battery.nuclear.geo,load_country_unif.gasprice_tri.siting_country_discrete_flat.upv_tri.nuclear_tri,,,,,,,,,,, | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added siting to the LHS case, but it's not yet supported. @bsergi let me know if you'd rather leave it out until we fix it for LHS. |
||
| MCS_lhs,,,,,,,,,,,,,,,,,,,,,1,,,,,,,,,,, | ||
| GSw_PRM_StressIterateMax,,,,,,,,0,,,,,,,,0,0,,,1,1,,,,,,,,,,, | ||
| GSw_ReducedResource,,,,,,,1,,,,,,,,,,,,,,,1,,,,,,,,,, | ||
|
|
||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could spend more time unifying the naming of the distributions in this file; let me know if you think we should do that here |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -414,11 +414,7 @@ def subset_to_valid_regions( | |
| full_path = full_path.format(**sw) | ||
| ## Filename conditions | ||
| if filename.startswith('supplycurve'): | ||
| df = reeds.io.assemble_supplycurve( | ||
| full_path, | ||
| case=os.path.dirname(os.path.normpath(inputs_case)), | ||
| agg=agg, | ||
| ).reset_index() | ||
| df = reeds.io.get_supplycurve(full_path, case=inputs_case) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now we just get the initial supply curve and assemble the full curve (i.e. add the interconnection costs) only once downstream in writesupplycurves.py, rather than assembling it twice (which complicates the MC sampling) |
||
| elif filename == 'techs_banned.csv': | ||
| df, nuclear_ban_regions = read_banned_tech_file( | ||
| full_path, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed from NE.NY.PA to Pacific to avoid the islanded-zones warning added in #243