Skip to content

Fix region label fontsize in compare_cases.py - #258

Merged
clairehalloran merged 1 commit into
mainfrom
ch/fontsize-fix
Oct 19, 2026
Merged

clairehalloran merged 1 commit into
mainfrom
ch/fontsize-fix

Conversation

@clairehalloran

@clairehalloran clairehalloran commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Squashes a small bug that #170 introduced into postprocessing/compare_cases.py by incorrectly specifying the fontsize in the reedsplots.label_region_value() calls. Thanks to @jvcarag for catching this!

Validation, testing, and comparison report(s)

I ran compare_cases.py for some existing cases and confirmed that no error is raised now. Absolute and difference capacity maps have non-overlapping labels.
image
image

Checklist for author

Details to double-check

  • Charge code provided to reviewers
    - [ ] Included comparison reports for appropriate test cases
    - [ ] Documentation updated if necessary
  • If input data added/modified:
    - [ ] Dollar year recorded and converted to 2004$ for GAMS
    - [ ] Timeseries are in Central Time
    - [ ] Units are specified
    - [ ] Preprocessing steps have been documented and committed to ReEDS_Input_Processing
    - [ ] New large data files handled with .h5 instead of .csv
    - [ ] If new parameters are added to d_objective.gms, they are included in objective_function_params.yaml for completeness checking
    - [ ] If spatially resolved inputs are modified, the following visualizations for each file are included in the PR description (time-averaged if the inputs are time-resolved):
    - [ ] Map of absolute values before
    - [ ] Map of absolute values after
    - [ ] Map of differences: (after - before) or (after / before)
  • If entries are added/removed/changed in the EIA-NEMS unit database:
    - [ ] Changes have been committed to ReEDS_Input_Processing
    - [ ] hourlize/resource.py was rerun to regenerate the existing/prescribed VRE capacity data
  • Code formatting standardized
  • Reusable functions used where possible instead of copy/pasted code

General information to guide review

- [ ] Zero impact on results of default case
- [ ] No large data file(s) added/modified
- [ ] No substantive impact on runtime for full-US reference case
- [ ] No substantive impact on folder size for full-US reference case
- [ ] No change to process flow (runreeds.py, reeds/core/solve/solve.py)
- [ ] No change to code organization
- [ ] No change to package requirements (environment.yml or Project.toml)

Did you use LLM tools (chatbot or copilot) in the preparation of this PR? If so, describe how

No.

Tag points of contact here if you would like additional review of the relevant parts of the model

@jvcarag jvcarag left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick-turnaround PR Claire: I also checked this fix on a compare_cases.py run using separate ReEDS runs and found the PR changes sufficiently fix the issue.

@clairehalloran
clairehalloran merged commit 89f1278 into main Oct 19, 2026
10 checks passed
@clairehalloran
clairehalloran deleted the ch/fontsize-fix branch October 19, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants