Repository navigation
Fix region label fontsize in compare_cases.py - #258
Merged
Merged
Conversation
jvcarag
approved these changes
Oct 19, 2026
jvcarag
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the quick-turnaround PR Claire: I also checked this fix on a compare_cases.py run using separate ReEDS runs and found the PR changes sufficiently fix the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Squashes a small bug that #170 introduced into
postprocessing/compare_cases.pyby incorrectly specifying the fontsize in thereedsplots.label_region_value()calls. Thanks to @jvcarag for catching this!Validation, testing, and comparison report(s)
I ran


compare_cases.pyfor some existing cases and confirmed that no error is raised now. Absolute and difference capacity maps have non-overlapping labels.Checklist for author
Details to double-check
- [ ] Included comparison reports for appropriate test cases- [ ] Documentation updated if necessary- [ ] Dollar year recorded and converted to 2004$ for GAMS- [ ] Timeseries are in Central Time- [ ] Units are specified- [ ] Preprocessing steps have been documented and committed to ReEDS_Input_Processing- [ ] New large data files handled with .h5 instead of .csv- [ ] If new parameters are added tod_objective.gms, they are included inobjective_function_params.yamlfor completeness checking- [ ] If spatially resolved inputs are modified, the following visualizations for each file are included in the PR description (time-averaged if the inputs are time-resolved):- [ ] Map of absolute values before- [ ] Map of absolute values after- [ ] Map of differences: (after - before) or (after / before)- [ ] Changes have been committed to ReEDS_Input_Processing- [ ]hourlize/resource.pywas rerun to regenerate the existing/prescribed VRE capacity dataGeneral information to guide review
- [ ] Zero impact on results of default case- [ ] No large data file(s) added/modified- [ ] No substantive impact on runtime for full-US reference case- [ ] No substantive impact on folder size for full-US reference case- [ ] No change to process flow (runreeds.py, reeds/core/solve/solve.py)- [ ] No change to code organization- [ ] No change to package requirements (environment.yml or Project.toml)Did you use LLM tools (chatbot or copilot) in the preparation of this PR? If so, describe how
No.
Tag points of contact here if you would like additional review of the relevant parts of the model