Skip to content

Update geopandas and cluster environment variables for RHEL9 on kestrel - #259

Open
patrickbrown4 wants to merge 5 commits into
mainfrom
pb/rhel9
Open

patrickbrown4 wants to merge 5 commits into
mainfrom
pb/rhel9

Conversation

@patrickbrown4

Copy link
Copy Markdown
Contributor

Summary

Kestrel has updated from Red Hat Enterprise Linux 8 (RHEL8) to RHEL9; details are available at https://natlabrockies.github.io/HPC/RHEL9_upgrade/. This PR makes a few necessary changes for the new OS.

Necessary steps for internal lab users on kestrel

  1. From now on, ssh into the kl3.hpc.nlr.gov node instead of kestrel.hpc.nlr.gov, kl1.hpc.nlr.gov, or kl2.hpc.nlr.gov (docs)
  2. Remove the old reeds conda environment: conda env remove --name reeds (say yes to all prompts)
  3. Rebuild the environment using the environment.yml file from this branch: conda env create -f environment.yml

Technical details

Implementation notes

  • The NREL_CLUSTER environment variable has been changed to NLR_CLUSTER. We used it in many places, so I moved all that functionality to reeds.slurm.get_cluster() to make it easier to update in the future.
    • I also removed the need for a REEDS_USE_SLURM environment variable as it doesn't seem necessary
    • Also removed the old references to eagle

Relevant sources or documentation

https://natlabrockies.github.io/HPC/RHEL9_upgrade/

Validation, testing, and comparison report(s)

I'll add a full-US comparison once it finishes.

Checklist for author

Details to double-check

  • Charge code provided to reviewers
  • Included comparison reports for appropriate test cases
  • Code formatting standardized
  • Reusable functions used where possible instead of copy/pasted code

General information to guide review

  • Zero impact on results of default case
  • No large data file(s) added/modified
  • No substantive impact on runtime for full-US reference case
  • No substantive impact on folder size for full-US reference case
  • No change to process flow (runreeds.py, reeds/core/solve/solve.py)
  • No change to code organization
  • No change to package requirements (environment.yml or Project.toml)

Did you use LLM tools (chatbot or copilot) in the preparation of this PR? If so, describe how

No

@cavraam cavraam left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks great, thank you for the prompt response here @patrickbrown4!

Approved, provided that pending runs complete; very minor comments/questions attached.

I wonder if the runs will reveal additional minor edits related to reporting (I don't think we have hpc-related scripts for reporting though...)

Comment thread hourlize/run_hourlize.py
import copy_rev_folders
from pathlib import Path
from collections import OrderedDict
sys.path.append(str(Path(__file__).parent.parent))

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why we might need this...

Comment thread reeds/slurm.py

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this defined in only one spot and call if needed

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants