Repository navigation
Conversation
|
Hi @bvdmitri, the CI workflows are showing "Action required" for my PR #335. I see this is a fork-based PR from ArpanC6:fix/293-constraint-error. Could you please approve the workflow runs so CI can start? The change is small: a descriptive hint in the invalid factorization constraint set error message plus a regression test. Thanks! |
| Base.length(label::NodeLabel) = 1 | ||
| Base.size(label::NodeLabel) = () | ||
| Base.getindex(label::NodeLabel, any) = label | ||
| Base.getindex(label::NodeLabel, i1, is...) = label |
There was a problem hiding this comment.
Why is this necessary for updating the error message?
There was a problem hiding this comment.
We dont have CHANGELOG in this repository and this PR should not add it
|
This PR also seems to be a copy of https://github.com/ReactiveBayes/GraphPPL.jl/pull/303/changes |
cc68b5a to
0b3221e
Compare
|
@bvdmitri thanks for the review. I've rebased the branch and addressed all three points
The diff is now just the error-message hint and its regression test. Could you please re-review and approve the workflow runs so CI can start? Thanks.. |
Fixes #293
The error message thrown when a factorization constraint set is invalid was hard to interpret. The raw BoundedBitSetTuple matrix printed in the error gave users no real guidance on what went wrong or how to fix it.
I added a short hint to the error message explaining what a valid constraint set actually requires so users have something actionable to go on rather than just a matrix of booleans.
Hint
A valid constraint set requires that each interface belongs to exactly one factorization group. In the constraint matrix, each column must have exactly one non-zero entry per group. Make sure all variables appearing in your model are included in your factorization constraint.
Changes
src/plugins/variational_constraints/variational_constraints_engine.jl- added hint to error messagetest/plugins/variational_constraints/variational_constraints_engine_tests.jl- added test asserting the hint is presentTest plan