Skip to content

WIP: Dev.ap/tip tap editor take 2 - #598

Draft
roedoejet wants to merge 14 commits into
mainfrom
dev.ap/tip-tap-editor-take-2
Draft

WIP: Dev.ap/tip tap editor take 2#598
roedoejet wants to merge 14 commits into
mainfrom
dev.ap/tip-tap-editor-take-2

Conversation

@roedoejet

Copy link
Copy Markdown
Collaborator

PR Goal?

Fixes?

Feedback sought?

Priority?

Tests added?

How to test?

Confidence?

Version change?

@semanticdiff-com

semanticdiff-com Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  packages/studio-web/src/app/studio/studio.component.spec.ts  75% smaller
  packages/studio-web/src/app/studio/studio.component.ts  63% smaller
  packages/studio-web/src/app/upload/upload.component.html  34% smaller
  packages/studio-web/src/app/upload/upload.component.ts  31% smaller
  packages/studio-web/src/app/studio/studio.service.ts  25% smaller
  packages/studio-web/src/i18n/messages.json  4% smaller
  packages/studio-web/tests/studio-web/make-read-along.spec.ts  2% smaller
  packages/studio-web/tests/test-commands.ts  1% smaller
  package-lock.json  1% smaller
  .agent_history/prompts.md Unsupported file format
  CLAUDE.md Unsupported file format
  implementation_plan.md Unsupported file format
  packages/studio-web/package.json  0% smaller
  packages/studio-web/src/app/app.module.ts  0% smaller
  packages/studio-web/src/app/text-format-dialog/text-format-dialog.component.html  0% smaller
  packages/studio-web/src/app/text-format-dialog/text-format-dialog.component.sass Unsupported file format
  packages/studio-web/src/app/text-format-dialog/text-format-dialog.component.spec.ts  0% smaller
  packages/studio-web/src/app/text-format-dialog/text-format-dialog.component.ts  0% smaller
  packages/studio-web/src/app/tiptap-text-editor/schema/nodes.ts  0% smaller
  packages/studio-web/src/app/tiptap-text-editor/schema/serializers.spec.ts  0% smaller
  packages/studio-web/src/app/tiptap-text-editor/schema/serializers.ts  0% smaller
  packages/studio-web/src/app/tiptap-text-editor/tiptap-text-editor.component.html  0% smaller
  packages/studio-web/src/app/tiptap-text-editor/tiptap-text-editor.component.sass Unsupported file format
  packages/studio-web/src/app/tiptap-text-editor/tiptap-text-editor.component.spec.ts  0% smaller
  packages/studio-web/src/app/tiptap-text-editor/tiptap-text-editor.component.ts  0% smaller
  packages/studio-web/src/app/upload/upload.component.sass Unsupported file format
  packages/studio-web/src/app/upload/upload.component.spec.ts  0% smaller
  packages/studio-web/src/i18n/messages.es.json  0% smaller
  packages/studio-web/src/i18n/messages.fr.json  0% smaller
  packages/studio-web/tests/studio-web/check-page-1.spec.ts  0% smaller

@roedoejet
roedoejet marked this pull request as draft July 22, 2026 23:56
@dhdaines

Copy link
Copy Markdown
Collaborator

Hi! Is this the PR to review?

@roedoejet
roedoejet force-pushed the dev.ap/tip-tap-editor-take-2 branch from 5feb9ab to 5676828 Compare July 23, 2026 23:21
@roedoejet

Copy link
Copy Markdown
Collaborator Author

Hi! Is this the PR to review?

Yes, but it's still a draft/work-in-progress. I'm making my way through the code still, but everything appears to be functional at the moment. I've only done the refactor to tiptap and the page break functionality so far. I haven't added the error highlighting but that will be in a different PR. #599 replaces the write/upload with a single upload button as discussed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants