Repository navigation
Fix Fuel Generator energy output querying the wrong receiver face - #873
Merged
Merged
Conversation
Refactor direction calculation to use opposite direction.
Owner
|
Hi, thanks for the detailed investigation and simple fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Fuel Generator energy output querying the wrong face of neighboring blocks.
The output direction is computed from a machine core toward its neighboring receiver, but the capability context must name the receiver face pointing back toward the generator. Reverse that direction for both output ports.
This prevents direct output into side-sensitive handlers such as Ender IO energy conduits from silently accepting zero energy. Oritech energy pipes hide the issue because their energy lookup ignores the queried direction.
Reported environment: Minecraft 26.1.2, Oritech 2.0.0-exp12, Ender IO 9.0.6-alpha. The same code remains in upstream branch 26.1 at the time of inspection.
How Has This Been Tested?
Suggested verification: test both generator ports in all four horizontal orientations, with Ender IO conduits connected to a non-full consumer; compare before and after the patch and verify an Oritech pipe still works.
Checklist