Repository navigation
Fix dedicated server crash in TooltipHelper.getEnergyText (I18n is client-only) - #875
Merged
Merged
Conversation
I18n is client-only. Since the Addon Splicer preview is built on the server (AddonSplicerBlockEntity.refreshOperation), getEnergyText is now reached on a dedicated server and crashes it with NoClassDefFoundError. Fixes Rearth#874.
Owner
|
Hi, huge thanks for testing and validating this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #874.
TooltipHelper.getEnergyTextusedI18n.getfor the k/M/B/T abbreviations. Since exp13 the Addon Splicer preview is built on the server (AddonSplicerBlockEntity.refreshOperation->SplicerPreview.of->HeartOfTheMachineAddonBlock.getShrinkTooltip->getFormattedEnergyChangeTooltip), so this method now runs on a dedicated server and crashes it withNoClassDefFoundError: net/minecraft/client/resources/language/I18nas soon as a machine with addons loads.This replaces the four
I18n.get(key)calls withComponent.translatable(key).getString(), which resolves through the currentLanguageon both sides and produces the same text on the client.Tested on a dedicated server (All the Mods 11 0.15.0-beta, NeoForge 26.1.2.126) by applying the same change to
getEnergyTextthrough a mixin.