Skip to content

Validate MultiSend overrides and add Safe regression tests - #37

Merged
aviggiano merged 3 commits into
mainfrom
codex/safe-utils-follow-up
Nov 4, 2026
Merged

aviggiano merged 3 commits into
mainfrom
codex/safe-utils-follow-up

Conversation

@aviggiano

@aviggiano aviggiano commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

An explicit MultiSend override with no code could report a successful batch without executing any calls. This rejects empty overrides when building batches on the current chain and tests that a valid custom deployment executes each call through the Safe.

Follow-up to #34, #35 and #36:

  • Add local Safe tests for forged approvals, wrong executors, transaction and nonce binding, malformed signatures, and mixed signature formats.
  • Add proposal validation tests for gas/refund field changes, malformed responses, and dishonest hashes, plus hash comparison against a local Safe.
  • Separate the single-call, batch, and on-chain approval examples. Document delegatecall trust, approval checks, and the Safe v1.3+ and zero gas/refund assumptions.
  • Skip the two live Transaction Service write tests unless SAFE_UTILS_LIVE_API_TESTS=true is set.

Validation: CI on Foundry 1.9.0 passed 91 tests and skipped 2 live-API tests. Fuzz tests ran 256 cases each. The updated validation suite also passed locally on Foundry 1.8.7. forge fmt --check and git diff --check passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T11:55:11.302562Z ad71fc9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@aviggiano
aviggiano merged commit 637e042 into main Nov 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant