Skip to content

evaluation: Edge evaluation pca-chosen - #432

Open
ntalluri wants to merge 29 commits into
Reed-CompBio:mainfrom
ntalluri:edge-evaluation-pca-chosen
Open

evaluation: Edge evaluation pca-chosen#432
ntalluri wants to merge 29 commits into
Reed-CompBio:mainfrom
ntalluri:edge-evaluation-pca-chosen

Conversation

@ntalluri

@ntalluri ntalluri commented Oct 30, 2025 •
edited by tristan-f-r
Loading

Copy link
Copy Markdown
Collaborator

Adding the code for the edge specific visualization function for the PCA chosen pathways. Closes #374

  • add in test cases / fix node test cases
  • update the docstrings
  • fix the visualization spacing

@ntalluri ntalluri added analysis Analysis of PRA outputs needed for benchmarking Priority PRs needed for the benchmarking paper labels Oct 30, 2025
@read-the-docs-community

read-the-docs-community Bot commented Oct 30, 2025 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 spras | 🛠️ Build #34378541 | 📁 Comparing baba322 against latest (07707bf)

  🔍 Preview build  

3 files changed
± genindex.html
± fordevs/modules.html
± fordevs/spras.html

tristan-f-r
tristan-f-r reviewed Oct 30, 2025
View reviewed changes
Comment thread Snakefile Outdated
Comment thread spras/evaluation.py Outdated
@ntalluri @tristan-f-r
Apply suggestions from code review
206c453 
Co-authored-by: Tristan F.-R. <pub.tristanf@gmail.com>
@ntalluri ntalluri mentioned this pull request Oct 30, 2025
Open
@ntalluri
ntalluri requested a review from agitter November 7, 2025 21:25
tristan-f-r
tristan-f-r reviewed Nov 7, 2025
View reviewed changes

@tristan-f-r tristan-f-r left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also drop https://github.com/ntalluri/spras/blob/206c45351dcfdd1109184ec6f602396bd7b3f3ce/spras/evaluation.py#L657-L677.

Comment thread spras/evaluation.py Outdated
Comment thread spras/evaluation.py
Comment thread Snakefile Outdated
@ntalluri ntalluri mentioned this pull request Nov 7, 2025
Open
1 task
ntalluri
ntalluri commented Nov 7, 2025
View reviewed changes
Comment thread spras/evaluation.py Outdated
agitter
agitter reviewed Nov 15, 2025
View reviewed changes

@agitter agitter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left initial comments and have not run it locally yet. The pre-commit check test is failing.

Comment thread test/evaluate/test_evaluate.py
Comment thread test/evaluate/test_evaluate.py Outdated
Comment thread test/evaluate/test_evaluate.py Outdated
Comment thread spras/evaluation.py Outdated
Comment thread spras/evaluation.py Outdated
tristan-f-r
tristan-f-r reviewed Nov 18, 2025
View reviewed changes
Comment thread spras/evaluation.py Outdated
@ntalluri

ntalluri commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

I think these test cases are also dealing with the pca tiebreaking issue. So these tests will break at random.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agitter agitter agitter left review comments
@tristan-f-r tristan-f-r tristan-f-r left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

analysis Analysis of PRA outputs needed for benchmarking Priority PRs needed for the benchmarking paper

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update evaluation code to include edge evaluation

3 participants

@ntalluri @agitter @tristan-f-r