Leaderboard update#46
Open
AdityaK2905 wants to merge 6 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the app’s leaderboard UI to a new “podium + scrollable list + footer CTA” layout for both signed-in and guest users, while also introducing build/config changes (EAS + Babel plugins) and removing/disablement of Firebase notification plumbing.
Changes:
- Rebuilds
leaderboardandleaderboard_guestscreens with new styles, podium rendering, and “Go to My Ranking” scrolling behavior. - Adds EAS configuration (
eas.json+extra.eas.projectId) and updates Babel plugins for Expo Router/Reanimated. - Disables/removes Firebase notification-related code paths (service, hook usage, toggle UI).
Reviewed changes
Copilot reviewed 10 out of 17 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| patches/react-native-webview+13.12.5.patch | Adds a patch-package patch for react-native-webview (currently includes IDE metadata + a rename). |
| lib/firebase.ts | Removes the Firebase notification service implementation. |
| hooks/useFirebaseNotifications.ts | Comments out the notifications hook implementation. |
| eas.json | Adds EAS build/submit profiles and CLI version constraint. |
| components/misc/NotificationToggle.tsx | Comments out the notification toggle UI (currently breaks consumers that still import it). |
| babel.config.js | Adds expo-router/babel + react-native-reanimated/plugin (last) and keeps NativeWind. |
| app/(tabs)/leaderboard/leaderboard.tsx | Replaces the signed-in leaderboard screen with new podium + list + footer design. |
| app/(tabs)/leaderboard/leaderboard_guest.tsx | Replaces guest leaderboard screen with new design and dummy data list. |
| app/_layout.tsx | Adds leaderboard fonts and disables useFirebaseNotifications() initialization. |
| app.config.js | Adds extra.eas.projectId for EAS project configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+6
| // import React, { useState, useEffect } from 'react'; | ||
| // import { View, Text, Alert, Linking, Platform, AppState } from 'react-native'; | ||
| // import { Ionicons } from '@expo/vector-icons'; | ||
| // import { AnimatedSwitch } from '@/components/switch/AnimatedSwitch'; | ||
| // import { useFirebaseNotifications } from '@/hooks/useFirebaseNotifications'; | ||
| // import FirebaseService from '@/lib/firebase'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.