Repository navigation
feat(realtime): per-topic flags, lint rules, toast limiter, virtualized lists - #411
Open
mike-programs wants to merge 1 commit into
Open
mike-programs wants to merge 1 commit into
mike-programs wants to merge 1 commit into
Conversation
…tualized lists Closes Refract-Protocol#288 Closes Refract-Protocol#292 Closes Refract-Protocol#307 Closes Refract-Protocol#308
|
@mike-programs Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #288
Closes #292
Closes #307
Closes #308
Summary
src/lib/realtime/flags.ts: per-topic flags inpublic/flags.json(realtime.topics.<topic>: {enabled, kill?}). Precedence: kill > in-memory override >NEXT_PUBLIC_REALTIME_TOPICS_OVERRIDE> flags.json > disabled. Malformed/unknown entries fail closed and are logged.realtimeClient.subscribeparks handlers for disabled topics (no subscription opened; callers use REST) and activates/tears down on mid-session flips; flag changes are observable viaonTopicFlagChange..eslintrc.json): bansnew WebSocket/EventSourceand deep@/lib/realtime/*imports outside the module, andrealtimeClient.subscribeoutsideuseEffect; tests are exempt; escape hatch documented in CONTRIBUTING.md.ToastLimiter(src/lib/notificationThrottle.ts): concurrency/rate caps, "+N more" overflow, critical priority never dropped, quiet-hours deferral queue, id dedup, reset on account switch. Presentation-layer only; not yet wired into the toast UI.VirtualList+computeWindow, applied to NotificationCenter above 50 items (unchanged markup below). No new dependency.Validation
viteston new tests: 11 pass.tsc: no errors in touched files.next lintfails on theLiteral[value=1e7]selector in the base config andsrc/app/cover/page.tsxhas TS syntax errors, so I could not run the full lint. Rules were verified against a good/bad fixture instead.