Repository navigation
Conversation
|
@gbolly122 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a bounded streamed-feed reveal buffer for issue #306. Incoming items are
kept separate from the rendered list while the reader is scrolled away or in a
background tab; a reveal commits them in descending timestamp order without
duplicates, and the state exposes the pending count, label, and reduced-motion
flag for a reveal control.
Closes #306
Type of change
What changed
src/lib/realtime/stream-reveal-buffer.tsStreamRevealBuffer<T>withpushIncoming,revealPending,setScrollPosition,setTabVisibility,setReducedMotion, andgetState.otherwise.
animateReveal: falsewhenreduced motion is requested.
src/lib/realtime/__tests__/stream-reveal-buffer.test.tsValidation
Checklist
CONTRIBUTING.mdmainissues: 16 trackedfiles are 0 bytes (including
src/app/layout.tsx,globals.css,Button.tsx,Navbar.tsx, and the coverage/pool hooks), andsrc/app/cover/page.tsxistruncated mid-component.
tsc/vitestfail onmainbefore this change.Notes for reviewers
This is the buffering primitive required by the issue. Wiring the control into
the landing/dashboard feeds depends on the missing hooks/pages above; I kept the
PR limited to the module and its tests so it can merge independently of that
restoration work.