Repository navigation
feat(realtime): warm shared connections and handle control frames - #427
Open
driftsorbit wants to merge 2 commits into
Open
driftsorbit wants to merge 2 commits into
driftsorbit wants to merge 2 commits into
Conversation
|
@driftsorbit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The app shell now owns one shared realtime client and warms it after hydration when the realtime flag is enabled. Navigation intent warms
/coverand/provide; reduced-data signals and the persisted opt-out preference suppress warm-up, and unused warm connections close after 15 seconds.The realtime client now uses an injected clock for reconnect, idle, and heartbeat timers. It handles
$controlrevocation, maintenance, drain, drain-complete, and ping/pong frames separately from domain events. Oracle, claim, and notification payloads map into frontend-owned domain types; claim amounts stay strings and claim timestamps normalize to Unix milliseconds for both REST and stream data.The deterministic mock compares a 100 ms connection handshake: first-event delay after a warm subscribe is 0 ms; cold subscribe is 100 ms. Control-frame tests verify revocation removal/no-op behavior, maintenance deferral, and immediate drain-complete reconnect.
Validation
git diff --check: passed.The repository-wide gates are blocked by upstream baseline issues:
package-lock.jsonis empty, sonpm cicannot install;src/app/cover/page.tsxhas existing JSX parse errors; and the full lint/test runs report existing lint violations, missing test dependencies, and unrelated test failures. These prevent confirming green full CI from this checkout.Closes #263
Closes #262
Closes #261
Closes #260