Repository navigation
Pin the fail-open branch of the harness-live rebind check - #727
Open
rensei-ai[bot] wants to merge 2 commits into
Open
rensei-ai[bot] wants to merge 2 commits into
rensei-ai[bot] wants to merge 2 commits into
Conversation
The rebind gate treats an unreadable registry record as live, carrying the read error alongside, so repair of a lineage the shim can still serve is never refused over a transient read failure. This pins that choice at both levels the seam exposes: the predicate reports live=true with the read error, and the caller proceeds past the gate toward the adoption dial instead of refusing harness-not-live.
Donmai native drift checkCommit: Policy passed. This is regex-based diff analysis, not a learned architectural baseline or a semantic review. |
…tion The required test job on this head fails only in TestAmbiguousLaunchCommitDoesNotStrandTheHost with a PTY spawn refused under runner process-count exhaustion. A local race run of that exact test passes, so the finding is environmental rather than caused by the test-only change. No production code touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only change: pins the rebind gate's fail-open branch for an unreadable registry record.
Scope: one regression test in daemon/session_shim_rebind_test.go. No production behavior changes.
What the test proves:
Load-bearing proof (isolated snapshot, production restored byte-identical afterwards):
Rework verification (2026-10-09, branch head 239d00c, production files untouched):
Blocking finding B1 (red CI test job on the prior head):
ptyhost: pty start: fork/exec /bin/sh: operation not permittedand runner nproc at its cap (nproc_cur=63136 nproc_max=63136).Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.