Repository navigation
Runner defers failure-side tracker transition for retry-eligible attempts - #776
Draft
rensei-ai[bot] wants to merge 2 commits into
Draft
rensei-ai[bot] wants to merge 2 commits into
rensei-ai[bot] wants to merge 2 commits into
Conversation
Donmai native drift checkCommit: Policy passed. This is regex-based diff analysis, not a learned architectural baseline or a semantic review. |
MarkKropf
marked this pull request as draft
October 4, 2026 10:50
Keeps the deferred failure-side transition intent; adopts main's newer behaviour (per-seat budget plumbing, continued-request guards) alongside it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defers the failure-side tracker transition when work opts in and a provider-error failure happens before any tool call, so a re-dispatch starts from the same state. The skipped transition is recorded on the terminal result for later completion.
Confirmed the current path first: a failed session on a result-sensitive type resolves to its fail status (agent-failed branch in runner/sdlc.go), including provider errors.
Rework update (merge with main): merged origin/main into this branch as a plain merge commit (no rebase/force-push). Two content conflicts resolved, both keeping both sides: runner/types.go keeps the per-work opt-in flag alongside the newer per-seat budget field; the queued-work translation keeps the opt-in flag alongside the newer budget mapping. One gofumpt alignment fix on the merged hunk. No scope change beyond the merge.
Changed test files and results on the merged tree (fresh, count=1):
Revert proof (mutated zero-tool-call gate to always defer, restored after):
Lint: 0 issues (golangci-lint run runner/... daemon/... afcli/...). Build: go build ./runner/... ./daemon/... ./afcli/... exit 0. gofmt: no diff. Guard: make guard exit 0 (self-tests OK, staged scan clean, identity clean, no-inbound-attach OK).
Smoke gap: no new smoke coverage in the smokes repo for this runner policy flag.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.