Repository navigation
Honor N64 4x resolution without silently lowering it to 3x - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting N64 4x in a saved profile or an explicit
--opt video.internal_resolution=4xsilently launched at 3x. Remove the Launcher policy introduced by #38: the menu now displays the core's declared resolutions, and the launch path preserves the requested scale. Current n64lle cores declare 1x through 4x. Existing validation of obsolete stored options and explicit invalid options remains in place.Validation: Windows Release Launcher and settings-test builds pass;
hub_core_settingspasses, including saved 4x and explicit 4x precedence. A separate private QA candidate retains the previously qualified 0.472 core and runner and contains the rebuilt Launcher. The owner requested a real 4x Fit-to-screen playtest; that candidate has been launched with normal audio. The startup wrapper records preflight and spawn timings, verifies the ROM/package/binary hashes, and restores its caller's environment.Previous whole-Launcher smoke and owner playtest actually ran at 3x. The separate production-consumer performance harness and gameplay resize qualification were actual 4x, as recorded in their core logs; those measurements remain valid. This change does not extend engine resolution beyond its declared 4x limit or qualify enhanced GPU rendering for netplay. Existing portable-profile netplay qualification and its documented simultaneous fault-injection failure remain unchanged.
Tracking: beads-hn9l.2.68. Stacked on #39 for this QA build; the resolution fix itself only removes the old Launcher cap. No merge authorized.