Repository navigation
Gate SPU HQ CD bypass on actual CD sample activity - #759
Merged
Merged
Conversation
mstan
force-pushed
the
fix/hle-sys03-closed-thread-context-20261024
branch
from
October 24, 2026 19:31
89bfffe to
541a9b0
Compare
A game can leave the SPU CD-enable bit set through voice-only play, which kept the HQ voice mix bypassed. Reported by michaelm-afk. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
mstan
force-pushed
the
fix/spu-shadow-cd-activity-gate-20261024
branch
from
October 24, 2026 19:32
a721429 to
4abfd37
Compare
mstan
changed the base branch from
fix/hle-sys03-closed-thread-context-20261024
to
integrate/tombi-eu-to-master-20261024
October 24, 2026 19:32
…dow-cd-activity-gate-20261024
mstan
marked this pull request as ready for review
October 24, 2026 23:51
mstan
changed the base branch from
integrate/tombi-eu-to-master-20261024
to
master
October 24, 2026 23:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A game can leave the SPU CD-enable bit set through voice-only play, which kept the HQ voice mix bypassed for the whole session. a721429 bypasses only while CD samples are queued or being consumed (including the last FIFO block); a reset/overflow counts as activity. Reported by michaelm-afk.
Test:
test_spu_shadow_normalizationextended; the new idle-CD-enable case fails on the old code and passes now.Stacked on #757.
🤖 Generated with Claude Code