Repository navigation
Land Tomba 2 widescreen cull work on master - #762
Merged
Merged
Conversation
mstan
marked this pull request as ready for review
October 24, 2026 23:51
mstan
added a commit
that referenced
this pull request
Oct 24, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tomba 2 master pins
f2a3b9be8onperf/tomba2-resident-60fps-20261008, which never reached master. Current master rejects Tomba 2'sgame.toml(masked_reject needs aligned BNE reg,zero).Ports the five widescreen commits that are missing from master (cherry-picked with
-x):[[widescreen.cull.packed_x]])masked_reject+ 4:3 identity; legacy backdrop compositesThe branch's guest_cycle_scale / batching commits are already on master (#561, #597, later revised), so they are not repeated. Fingerprints regenerated.
Conflicts were additive (master gained SXY cull + quality presets beside the same lines). The interpreter SLTU precedence is now packed-X → scale → keep → screen-X band, matching the code generator.
ctest: same 12 pre-existing failures as master, no new ones; new ws_cull codegen/interp tests pass.
🤖 Generated with Claude Code