Repository navigation
Move PSX enhancement settings to built-in mods; remove Graphics presets - #766
Merged
Merged
Conversation
…hics presets CRT Filter, Image Filtering, Enhanced Audio and Rewind become default-off mods (netplay = host_only, outside the plan fingerprint); Internal resolution gains Auto in place of dynamic resolution. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…-rate setting; host-only mod options editable in netplay Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
mstan
marked this pull request as ready for review
October 25, 2026 03:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings keeps PC/system things; game-output enhancements become built-in mods (beads-eio.3.398; rule: recomp-ui docs/SETTINGS_STANDARD.md).
game_id = "*", pluginsnetplay = "host_only"): CRT Filter, Image Filtering (Smoothing = linear present, not FXAA), Enhanced Audio, Rewind (psx.feature.rewind), Internal Resolution (psx.enhancement.internal-resolution: Game default / Native … 8K / Match display / Auto). Activation only records; the renderer setup resolves over the title's game.toml baseline every session. "Game default" = baseline.gl_renderer_set_internal_scale_livepath as the debug server'svideo_set; refused (applies next start) during netplay or without a live-capable backend. Precedence:PSX_INTERNAL_RESOLUTION> a title mod'spsx_mod_set_internal_resolution> the built-in mod > the title.netplay = "host_only"(out of the plan fingerprint, per player in every netplay mode) and featurevsync = "off"(RecompLauncherCModFeature.forces_vsync_off).mh_mod_set+psx_mod_option_live_host_only); everything else stays fixed for the match.[quality.*]table is a load error.[audio] frequency): ignored on read, dropped on save. Audio opens at the built-in 44.1 kHz; Volume stays. Launcher/in-game Settings rows, launcher round trips andPsxHostVideoSettingspersistence for them removed.-DPSX_REWIND=OFFbuilds do not stagepsx.feature.rewind. OpenBIOS emitter stamp refreshed (generated C unchanged).Pairs with RetroPortingToolKit/recomp-ui
feat/settings-to-builtin-mods-20261024(built and tested against it only).Tests: new
host_enhancements_test(incl. Internal Resolution),menu_launcher_callbacks_test; updated manifest/mod_packages/mod_runtime/settings/internal-resolution/scale-guard tests. Recompiler tree 146/156, the 10 failures all fail on master. Runtime tree: every failure also fails on master.🤖 Generated with Claude Code