Repository navigation
Exercise generated tail wrappers with runtime ancestor unwind accounting - #195
Merged
mstan merged 1 commit intoOct 21, 2026
Conversation
mstan
approved these changes
Oct 21, 2026
mstan
left a comment
Member
There was a problem hiding this comment.
Test-only addition. The fixture exercises emitted tail wrappers and production ancestor resolvers; it preserves the existing runtime implementation and tests sentinel propagation and context consumption.
Validation: five-head integration passed 826 Python tests (2 skipped) and 109 Rust tests. After excluding #198 for its separate title-save compatibility blocker, the four-head combination passed all 69 focused tests. Linux, Windows, macOS and Lua CI are green for this reviewed head. No new cross-title gameplay playtest is claimed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ROM-free execution coverage for the shared-tail return problem encountered during ISSD Native bring-up. Current main already handles this using tail-entry markers in the runtime, so this PR preserves that implementation and adds a regression rather than applying the older downstream per-wrapper decrement.
The test compiles an actual emitted past-end tail statement together with the production context-adoption functions and ancestor/post-return resolvers. It exercises one to three tail wrappers, normal returns, pre-RTS and post-RTS ancestor skips, unchanged LLE unwind sentinels, and discarded/consumed context.
Validation:
python -m pytest tests/v2/test_tail_unwind_execution.py -q: 1 passed (12 tail-chain scenarios plus context checks).The test executes production resolver bodies and emitted wrapper code; its frame push/prologue and ordinary caller continuation are modeled by the fixture. It does not establish cross-title gameplay coverage. No runtime behavior, game ROM, or generated commercial-game source changes.