Repository navigation
Conversation
mstan
approved these changes
Oct 21, 2026
mstan
left a comment
Member
There was a problem hiding this comment.
Reviewed Python/native range validation and independent M/X operand handling. Invalid negative/out-of-bank sites now fail instead of silently selecting another instruction; compiled observer/live-operand and cache invalidation coverage passes.
Validation: five-head integration passed 826 Python tests (2 skipped) and 109 Rust tests. After excluding #198 for its separate title-save compatibility blocker, the four-head combination passed all 69 focused tests. Linux, Windows, macOS and Lua CI are green for this reviewed head. No new cross-title gameplay playtest is claimed.
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
live_operandandentry_hookdocument local 16-bit PCs but silently truncated negative or 24-bit inputs, potentially selecting another instruction. Reject these inputs in Python and native live-operand parsing instead of masking them to 16 bits.This contribution grew out of ISSD Native's configurable runtime operands and instruction hooks. Current upstream already provides those facilities under
live_operandandentry_hook, so this PR strengthens them rather than introducing duplicate directives or mutable observers that invalidate analysis facts. Rust continues to ignore observational entry hooks because they are emission-only.Add compiled execution coverage across A/X/Y, both independent M/X widths, and banks $03/$83 with DB pointing to WRAM. Exercise same-site observers before operand reads, repeated ROM edits against the same compiled routine, and add/remove configuration-cache invalidation. Document local-PC addressing and migration from downstream directive names.
Validation:
python -m pytest tests/v2/test_live_operand.py tests/v2/test_entry_hook.py tests/v2/test_program_emit.py -q: 62 passed.tests/v2: 567 passed and one missing-submodule-header failure; after initializing lib/recomp-net, that case passed on targeted rerun (568 cases verified across those runs).git diff --checkclean.Broad local pytest initially reported 790 passed, 21 failed, 6 skipped: 20 shell-discovery failures and the missing-header case above. The header failure is resolved; no claim of a fully green broad run is made. Rustfmt was unavailable. No ROM or commercial game source included.