Skip to content

Make regeneration test runs visible and isolate scaffold fixtures - #211

Merged
mstan merged 2 commits into
mainfrom
fix/regen-test-output-20261024
Oct 24, 2026
Merged

mstan merged 2 commits into
mainfrom
fix/regen-test-output-20261024

Conversation

@mstan

@mstan mstan commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

Consumer regeneration exposed two problems in the framework test step:

  • On Windows, CREATE_NO_WINDOW can leave the test child without usable inherited console handles, hiding all diagnostics. Forward the caller’s stdout and stderr explicitly.
  • Scaffolder fixtures inherit SNESRECOMP_ROOT from the consumer build. The missing-submodule test then legitimately generates through that external checkout and fails its expected repair-hint assertion. Clear the inherited override in scaffold fixtures; cases that need a framework already provide one explicitly.

Validation on native Windows:

  • Both real child-process output tests failed before the stream fix and pass afterward, covering success and failure status.
  • The missing-submodule failure was reproduced with the consumer’s checkout override; all focused scaffold/output tests now pass: 31 passed, 1 skipped, with that override still set in the parent.
  • The separate runtime review bundle passes 856 tests, 2 skipped in the normal standalone environment.

This changes test execution and fixture isolation only; no generated code or built runtime changes. Tracking: beads-h6si.

mstan added 2 commits October 24, 2026 11:12
Pass the redirected streams explicitly when launching the no-console test child, preserving failure status and readable diagnostics. Verify stdout/stderr on real success and failure subprocesses. Refs beads-h6si.
@mstan mstan changed the title Preserve framework test output during Windows regeneration Make regeneration test runs visible and isolate scaffold fixtures Oct 24, 2026
@mstan
mstan merged commit 82b4acb into main Oct 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant