Repository navigation
Conversation
|
@ASIDISG Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
ASIDISG
added a commit
to ASIDISG/Revora-Contracts
that referenced
this pull request
Sep 28, 2026
Fixes the CI / Format check (cargo fmt) gate on PR RevoraOrg#1279. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
ASIDISG
force-pushed
the
test/1060-cancel-issuer-transfer-coverage
branch
3 times, most recently
from
September 29, 2026 16:52
dc9b385 to
5551487
Compare
Brings master in line with the repository's own Format check (cargo fmt --all -- --check), which fails on master today (40 hunks). Formatting only; no code or test changes.
New module src/test_issuer_transfer_cancel.rs and its mod declaration. Closes RevoraOrg#1060.
ASIDISG
force-pushed
the
test/1060-cancel-issuer-transfer-coverage
branch
from
October 16, 2026 01:41
5551487 to
70c1156
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
src/test_issuer_transfer_cancel.rs, an adversarial suite for the issuer-side cancel of a pending issuer transfer.iss_cancevent with(cancelling_issuer, cancelled_target); entry consumed (second cancel isNoTransferPending); offering stays fully operational under the original issuerOfferingNotFound; no pending proposalNoTransferPending(also wrong namespace, and cancel after accept);ContractFrozen;ContractPausedOfferingNotFound; the new issuer after accept isNotAuthorized(cancel identifies the primary issuer by identity beforerequire_auth, which is the observable layer throughtry_*)Closes #1060
Independence and verification
src/test_issuer_transfer_cancel.rsplus its two-linemoddeclaration insrc/lib.rs, on top of the sharedstyle: cargo fmt --allcommit (test: make the lib test target build and run to completion #1272 carries the identical commit, so the four test PRs and test: make the lib test target build and run to completion #1272 merge in any order without conflicts; I checked all orders by merging them together).cargo fmt --all -- --checkis clean on this branch.master's lib test target does not currently compile; test: make the lib test target build and run to completion #1272 fixes that. Verification was run on this branch merged with test: make the lib test target build and run to completion #1272:and with all four test branches merged together: 53 passed, 0 failed.
Not claimed
The earlier version of this PR stacked on the other three and quoted "307 passed" from a different base. Those numbers are gone; the figures above are what this branch produces.