Skip to content

test: add adversarial propose_transfer_with_expiry coverage (#1057) - #1280

Closed
ASIDISG wants to merge 2 commits into
RevoraOrg:masterfrom
ASIDISG:test/1057-propose-transfer-with-expiry
Closed

ASIDISG wants to merge 2 commits into
RevoraOrg:masterfrom
ASIDISG:test/1057-propose-transfer-with-expiry

Conversation

@ASIDISG

@ASIDISG ASIDISG commented Sep 28, 2026 •

Copy link
Copy Markdown

Summary

Adds src/test_propose_transfer_with_expiry.rs, an adversarial suite for propose_transfer_with_expiry.

Axis Cases
Expiry storage 0 is stored as the default marker; an in-range value is stored verbatim
Clamping boundaries below the one-hour minimum clamps up; above the 30-day maximum clamps down; the exact boundary values are stored verbatim
Success exactly one iss_prop event with its payload
Typed rejections unknown offering OfferingNotFound; proposal while one is pending is an error and state is unchanged; the new issuer after accept gets OfferingNotFound; ContractFrozen (no state written); ContractPaused (succeeds after unpause)
Lifecycle a proposal after cancel starts a fresh slot

Closes #1057

Independence and verification

cargo test --lib test_propose_transfer_with_expiry::
test result: ok. 12 passed; 0 failed

and with all four test branches merged together: 53 passed, 0 failed.

Not claimed

The earlier version of this PR stacked on the other three and quoted "307 passed" from a different base. Those numbers are gone; the figures above are what this branch produces.

@drips-wave

drips-wave Bot commented Sep 28, 2026

Copy link
Copy Markdown

@ASIDISG Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

ASIDISG added a commit to ASIDISG/Revora-Contracts that referenced this pull request Sep 28, 2026
Fixes the CI / Format check (cargo fmt) gate on PR RevoraOrg#1280.

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>
@ASIDISG
ASIDISG force-pushed the test/1057-propose-transfer-with-expiry branch 4 times, most recently from cf221fb to 239c9a6 Compare September 29, 2026 16:52
Brings master in line with the repository's own Format check (cargo fmt --all -- --check), which fails on master today (40 hunks). Formatting only; no code or test changes.
…g#1057)

New module src/test_propose_transfer_with_expiry.rs and its mod declaration. Closes RevoraOrg#1057.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add adversarial coverage for propose_transfer_with_expiry in lib

2 participants