Skip to content

test: add adversarial replace_issuer_transfer coverage (#1058) - #1281

Closed
ASIDISG wants to merge 2 commits into
RevoraOrg:masterfrom
ASIDISG:test/1058-replace-issuer-transfer
Closed

ASIDISG wants to merge 2 commits into
RevoraOrg:masterfrom
ASIDISG:test/1058-replace-issuer-transfer

Conversation

@ASIDISG

@ASIDISG ASIDISG commented Sep 28, 2026 •

Copy link
Copy Markdown

Summary

Adds src/test_replace_issuer_transfer.rs, an adversarial suite for replace_issuer_transfer.

Axis Cases
Success replace swaps the target, restamps the timestamp and preserves the window; the zero default marker is preserved; replace with the same target restamps; one atomic iss_canc + iss_prop event pair
Typed rejections unknown offering OfferingNotFound; no pending transfer, wrong namespace and replace after accept are NoTransferPending; the new issuer after accept is NotAuthorized; ContractFrozen and ContractPaused (the pending proposal survives, and replace works after unpause)
Boundary after a replace the default window accepts exactly one default window after the replace time; a custom window uses the preserved seconds from the replace time
Isolation replacing one offering's proposal leaves a sibling offering's untouched

Closes #1058

Independence and verification

cargo test --lib test_replace_issuer_transfer::
test result: ok. 14 passed; 0 failed

and with all four test branches merged together: 53 passed, 0 failed.

Not claimed

The earlier version of this PR stacked on the other three and quoted "307 passed" from a different base. Those numbers are gone; the figures above are what this branch produces.

@drips-wave

drips-wave Bot commented Sep 28, 2026

Copy link
Copy Markdown

@ASIDISG Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

ASIDISG added a commit to ASIDISG/Revora-Contracts that referenced this pull request Sep 28, 2026
Fixes the CI / Format check (cargo fmt) gate on PR RevoraOrg#1281 and re-stacks
the branch onto the formatted RevoraOrg#1057 tip.

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>
@ASIDISG
ASIDISG force-pushed the test/1058-replace-issuer-transfer branch 4 times, most recently from ab02ee9 to 1db1168 Compare September 29, 2026 16:52
Brings master in line with the repository's own Format check (cargo fmt --all -- --check), which fails on master today (40 hunks). Formatting only; no code or test changes.
New module src/test_replace_issuer_transfer.rs and its mod declaration. Closes RevoraOrg#1058.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add adversarial coverage for replace_issuer_transfer in lib

2 participants